-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #37140 - Update web UI for SCA-only #10880
Fixes #37140 - Update web UI for SCA-only #10880
Conversation
3fcda8d
to
1476a39
Compare
Many test failures should be fixed when #10861 is merged. |
@jeremylenz Do you want me to make a pr to pull stuff out of the old UI or say just leave like you said since it's going away. |
The cleanup is in a future epic; I think it will be fine until then |
That's covered in #10882 :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine with hammer and checked the UI and all of the pages you touched are updated correctly and poked around on some other pages and found an issue on the all hosts page - see comment below.
Update the Organization list page to remove the 'Simple Content Access' column - Pass
Update the Organization Create and Edit pages to remove the SCA checkbox and banner - Pass
Update Katello::OrganizationCreator to no longer accept an sca: keyword on initialization - Pass
As we discussed I found this with your other pr when testing this one on the all hosts page:
Which you will fix in your other PR. Thanks for getting this fixed up and when we get to the other epic for the old UI, I will get a PR for that going. Code looks fine too from a Ruby/JS standpoint.
Tested with #10882 and I do not hit the DB error anymore and the |
[test katello] |
ae271a9
to
36d1bf6
Compare
[test katello] |
36d1bf6
to
500f225
Compare
The label field was removed probably accidentally in Katello#10880. This action is still doable in api so it should be doable in UI as well.
The label field was removed probably accidentally in #10880. This action is still doable in api so it should be doable in UI as well.
What are the changes introduced in this pull request?
Katello::OrganizationCreator
to no longer accept ansca:
keyword on initialization.Considerations taken when implementing this change?
I'm trying to keep this PR to only removing visual elements that users would see in the web UI, rather than API endpoints or other backend code. But I did have to touch a few places that weren't strictly UI code.
I'm not bothering to surgically remove things from the legacy content host Angular UI, since that entire UI is going away soon anyway, and is already not displayed to users since all organizations now use SCA.
What are the testing steps for this pull request?
Check all the locations above and confirm that UI elements are removed
Poke around and make sure nothing is broken
Make sure CI tests pass and make sense