Project modernization #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
include_directories(${GKLIB_PATH}/include)
change the directory of files
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
LecrisUT
force-pushed
the
cmake/modernization
branch
from
e3b23da to
3379e9f
Compare
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
LecrisUT
force-pushed
the
cmake/modernization
branch
from
3379e9f to
1ba74b3
Compare
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
augusew1
reviewed
May 28, 2024
| # win32/adapt.h | ||
| # ) | ||
| if (GKLIB_INSTALL) | ||
| install(FILES win32/adapt.h ${CMAKE_INSTALL_INCLUDEDIR}/win32) |
There was a problem hiding this comment.
Typo here, should be
install(FILES win32/adapt.h DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}/win32| add_feature_info(GKLIB_OpenMP GKLIB_OpenMP "OpenMP support") | ||
| option(GKLIB_PCRE "GKlib: Enable PCRE support" OFF) | ||
| add_feature_info(GKLIB_PCRE GKLIB_PCRE "PCRE support") | ||
| cmake_dependent_option(GKLIB_GKREGEX "GKlib: Enable GKREGEX support" OFF "NOT GKLIB_PCRE" OFF) |
There was a problem hiding this comment.
Logic error here, it should be
Need to add `-GKLIB_GKREGEX=ON`
```cmake
# Second "OFF" should be "ON"
cmake_dependent_option(GKLIB_GKREGEX "GKlib: Enable GKREGEX support" OFF "NOT GKLIB_PCRE" ON)| include(FetchContent) | ||
| if (GKLIB_INSTALL) | ||
| include(CMakePackageConfigHelpers) | ||
| if (UNIX) |
There was a problem hiding this comment.
This should be unconditional, it's not an issue for this on Windows. And also, you use e.g. CMAKE_INSTALL_BINDIR unconditionally later on which expands to nothing on Windows currently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the counterpart of KarypisLab/METIS#79