Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only link to metabolites with data #222

Closed
yosefdroth opened this issue Apr 28, 2020 · 5 comments
Closed

Only link to metabolites with data #222

yosefdroth opened this issue Apr 28, 2020 · 5 comments
Labels
enhancement New feature or request

Comments

@yosefdroth
Copy link
Contributor

On the reactions page, it currently links every metabolite to a metabolite page.
example
However, not all metabolites have data, and therefore they lead to an empty page. Only metabolites with data should have links.

@jonrkarr
Copy link
Member

This is related to #155

@jonrkarr jonrkarr added the enhancement New feature or request label Apr 29, 2020
@yosefdroth
Copy link
Contributor Author

solved in update_metab

@jonrkarr
Copy link
Member

This doesn't appear to solved.

Example: http://localhost:3000/reaction/Isatin,NADH--%3E2%2C3-Dihydroxyindole,NAD%2B

If these metabolite pages aren't not intended to be valid, the reaction pages shouldn't have links to these invalid pages.

@lzy7071
Copy link
Contributor

lzy7071 commented May 14, 2020

This doesn't appear to solved.

Example: http://localhost:3000/reaction/Isatin,NADH--%3E2%2C3-Dihydroxyindole,NAD%2B

If these metabolite pages aren't not intended to be valid, the reaction pages shouldn't have links to these invalid pages.

Use /metabolites/meta/?inchikey= endpoint to get meta information and use /metabolites/concentrations/?inchikey= for data on concentration. Both endpoints will return an empty object if no meta / concentration information is found. When a link provided leads to a metabolite not found, rather than displaying an error prompt, the page can display "information not found" for the default panels (description, cross-references, etc.) using something to the effect of obj.description || "information not found". This avoids the need to "peek" to see if a metabolite exists in database.
Currently, frontend is still using /metabolites/concentration/ endpoint, which shouldn't be used at this point.

@lzy7071 lzy7071 mentioned this issue May 14, 2020
@jonrkarr
Copy link
Member

This appears to be addressed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants