Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs #225

Closed
yosefdroth opened this issue Apr 30, 2020 · 8 comments
Closed

Bugs #225

yosefdroth opened this issue Apr 30, 2020 · 8 comments
Assignees
Labels
bug Something isn't working

Comments

@yosefdroth
Copy link
Contributor

At https://datanator.info/reaction/Potassium%20ferrocyanoferrate(II),O2--%3EUnknown,H2O/Escherichia%20coli click on 'Unknown’ fails
Accessing https://datanator.info/metabolite/2-Hydroxybenzyladenine/Escherichia%20coli generates server error.

@yosefdroth yosefdroth self-assigned this Apr 30, 2020
@yosefdroth yosefdroth added the bug Something isn't working label Apr 30, 2020
@lzy7071
Copy link
Contributor

lzy7071 commented Apr 30, 2020

This is initially caused by a NoneType exception error. There is still an error now because there is no metabolite named 2-Hydroxybenzyladenine in metabolite_meta because the meta collection was built from metabolites in ecmdb and ymdb.

@yosefdroth
Copy link
Contributor Author

solved in update_metab

@jonrkarr
Copy link
Member

The second example still generates a server error
http://localhost:3000/metabolite/2-Hydroxybenzyladenine/Escherichia%20coli

@lzy7071
Copy link
Contributor

lzy7071 commented May 14, 2020

@jonrkarr
Copy link
Member

@lzy7071
Copy link
Contributor

lzy7071 commented May 20, 2020

This still displays an error
http://localhost:3000/metabolite/PHKMLSOXANWAKN-UHFFFAOYSA-N/Escherichia%20coli%20E1002

That was my bad, the inchikey for 2-hydroxyhexadecanal is BKBDVQVDRVGXKT-UHFFFAOYSA-N. So the actual link should have been https://datanator.info/metabolite/BKBDVQVDRVGXKT-UHFFFAOYSA-N/Escherichia%20coli%20E1002.

It is still giving an error, perhaps the reason being endpoint /metabolites/concentration/?metabolite= https://api.datanator.info/metabolites/concentration/?metabolite=BKBDVQVDRVGXKT-UHFFFAOYSA-N&abstract=true&species=Escherichia%20coli%20E1002 is still being used. The endpoint is obsolete and it takes metabolite name rather than inchikey as the query parameter.

The meta information of the metabolite is being returned using /metabolites/meta/?inchikey= https://api.datanator.info/metabolites/meta/?inchikey=BKBDVQVDRVGXKT-UHFFFAOYSA-N

To retrieve concentration information, one should use /metabolites/concentrations/similar_compounds/ http://api.datanator.info/metabolites/concentrations/similar_compounds/?inchikey=BKBDVQVDRVGXKT-UHFFFAOYSA-N&threshold=0.6&target_species=homo%20sapiens&taxon_distance=false
.

@jonrkarr
Copy link
Member

The update_metab branch is using the new endpoint. This isn't integrated into the master branch yet, and deployed.

@jonrkarr jonrkarr self-assigned this May 20, 2020
@jonrkarr
Copy link
Member

I think this is now fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants