Add brain graph generator. #50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielSeemaier
approved these changes
Oct 1, 2024
| @@ -428,6 +429,18 @@ This is mostly useful for experimental graph generators or when using KaGen to l | |||
| cmd->add_option("--cols-per-pe", config.image_mesh.cols_per_pe, "Number of columns assigned to the same PE"); | |||
| cmd->add_option("--rows-per-pe", config.image_mesh.rows_per_pe, "Number of rows assigned to the same PE"); | |||
| } | |||
| { // BRAIN | |||
| auto* cmd = app.add_subcommand("brain", "R-MAT Graph"); | |||
| #include <algorithm/AlgorithmEnum.h> | ||
| #include <mpi.h> | ||
|
|
||
| #include "algorithm/BarnesHutInternal/BarnesHutCell.h" |
There was a problem hiding this comment.
use <> instead of "" since these are not project files
| #include "sim/Simulation.h" | ||
| #include "sim/random/SubdomainFromNeuronPerRank.h" | ||
| #include "structure/Partition.h" | ||
| #include <memory> |
| break; | ||
| case BrainSynapseCreationModel::BARNES_HUT_INVERTED: | ||
| algorithm = AlgorithmEnum::BarnesHutInverted; | ||
| break; |
| : _sim(std::make_unique<Essentials>(), std::shared_ptr<Partition>(nullptr)), | ||
| _config(config.brain), | ||
| _rank(rank) { | ||
| MPIWrapper::init(1, nullptr); |
There was a problem hiding this comment.
does this call MPI_Init? wouldn't that crash?
the "KaGen" way would be to use Finalize() for everything that requires communication (the communicator is only passed to Finalize()), but obviously, this is stroingly biased by the communication free nature of KaGen.
Should we generate the entire graph there or keep it as it? Personally I don't have a strong opinion on whether we should stick to this model or not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.