Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][era][cata]: Compatibility updates with LFGBulletinBoard minimap button #236

Conversation

juemrami
Copy link
Contributor

@juemrami juemrami commented Aug 21, 2024

Related Issues:

In this PR:
Button will now get handled but the LibDBIcon-1.0 if our users are using it.

Compatibility function now only skins the non LibDBIcon-1.0 compliant minimap button from LFGBulletinBoard. This allows us (LFGBulletinBoard) to maintain functionality of not having the button anchored to the minimap perimeter.

Images
(Non LibDBIcon version. Skinned and aligned with other LibDB ones, maintains our addons functionality still)
WowClassicT_upW4dIajlc

(LibDBIcon managed version enabled. Your addon will treat it like any other LibDBIcon button)
WowClassicT_Nw7FsTsoHH

  • Note: A reload is required on our end when toggling LibDBIcon mode for it to actually take effect, so no additional logic required for edge cases there.

Tested On

  • Era & SoD
  • Cataclysm

@Karl-HeinzSchneider Karl-HeinzSchneider added the bug Something isn't working label Aug 24, 2024
@Karl-HeinzSchneider Karl-HeinzSchneider merged commit 7b5f0e0 into Karl-HeinzSchneider:main Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants