Select track UI implemented #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErykKrupa
requested changes
Jun 7, 2020
src/view/options_menu.py
Outdated
| self.divider = 0.4 | ||
| self.selected_action: Optional[Action] = None | ||
| self.img = pygame.image.load("resources/graphics/track1.jpg") | ||
| self.logo_image = pygame.image.load("resources/graphics/logo.png") | ||
|
|
||
| def draw(self, destination: Surface, events: List[EventType]) -> Optional[Action]: |
There was a problem hiding this comment.
It's a very long method, maybe we can split it?
mareksmorag
force-pushed
the
UI_select_track
branch
from
0d91676 to
f99928b
Compare
ErykKrupa
requested changes
Jun 11, 2020
src/main.py
Outdated
Comment on lines
80
to
103
| tv1 = TrackView(Track.from_points(tracks[1]["points"])) | ||
| tv2 = TrackView(Track.from_points(tracks[3]["points"])) | ||
| tv3 = TrackView(Track.from_points(tracks[4]["points"])) | ||
|
|
||
| track_options = { | ||
| "Track1": Action(ActionType.CHANGE_VIEW, 2), | ||
| "Track2": Action(ActionType.CHANGE_VIEW, 3), | ||
| "Track3": Action(ActionType.CHANGE_VIEW, 4), | ||
| } | ||
| track_images = [ | ||
| pygame.image.load("resources/graphics/track1.jpg"), | ||
| pygame.image.load("resources/graphics/track2.jpg"), | ||
| pygame.image.load("resources/graphics/track3.jpg") | ||
| ] | ||
| options_menu = OptionsMenu(tracks=track_options, tracks_thumbnails=track_images) | ||
| options_menu.background_image = pygame.image.load( | ||
| "resources/graphics/menu-background.png" | ||
| ) | ||
|
|
||
| window.add_view(menu, 0, True) | ||
| window.add_view(tv1, 1) | ||
| window.add_view(tv2, 2) | ||
| window.add_view(tv1, 2) | ||
| window.add_view(tv2, 3) | ||
| window.add_view(tv3, 4) | ||
| window.add_view(options_menu, 1) |
There was a problem hiding this comment.
Previews for second and third tracks are not corresponding to actual tracks. Please fix it and add the forth track also. Furthermore, we can give them nicer names like "DNA", "Straight", "Loop" and so on.
There was a problem hiding this comment.
To be fixed when last two tracks will be merged
jakubdabek
requested changes
Jun 14, 2020
ErykKrupa
approved these changes
Jun 15, 2020
KamilKrol5
approved these changes
Jun 15, 2020
jakubdabek
approved these changes
Jun 21, 2020
ErykKrupa
requested changes
Jun 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.