Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aggregation Pull Request #2 #56

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Aggregation Pull Request #2 #56

wants to merge 4 commits into from

Conversation

Zy8712
Copy link

@Zy8712 Zy8712 commented Mar 17, 2021 •
edited
Loading

Commit: "Aggregation Pull Request #2"

  • Unlike last time, I actually correctly executed my pull request on a separate branch...
  • Continuing off of my previous pull request, I made an indication as to the divide I made between generalized data searches and specific country-based data searches
  • In this pull request I divide the previous COVID19DataRetrieval class further down into two separate classes, COVID19GeneralizedDataRetrieval and COVID19CountryBasedDataRetrieval
  • Methods in the COVID19GeneralizedDataRetrieval class are mainly those that don't require much specification or information (getAll, getLatest, etc.)
  • Methods in the COVID19CountryBasedDataRetrieval class are mainly those that require specific information from the user (get data by country code/name/id)

Further details regarding this pull request will be stated in the report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Zy8712