Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregation Pull Request #1 #51

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Zy8712
Copy link

@Zy8712 Zy8712 commented Mar 17, 2021

Commit: "Inserted comments and made minor changes"

  • Partially a test pull request
  • Fixed some lines of code I felt were outstanding issues
  • Inserted comments on the same lines as those which I fixed

=== Lines Changed ===
from **prams to *prams

  • gave a syntax error before

from latestData to previousData

  • originally latestData was subtracting from itself to find changes, but its suppose to subtract from previousData to find changes

////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////

Commit: "Aggregation Pull Request #1"

  • I didn't realize that I had to create a new branch in order to have a separate pull request, hence the aggregation pull request ended up here with the initial test pull request. I have renamed the test pull request to officially be the first pull request in order to avoid any possible confusion.
  • I've split the original COVID19 class into two separate classes, UserRequestSetup and COVID19DataRetrieval
  • All methods associated with the setup for the user's data retrieval request (selecting sources, send request, etc.) are under the UserRequestSetup class
  • All methods associated with the data retrieval process (retrieving by country name/id/code, updates, get all, etc.) are under the COVID19DataRetrieval class
  • Methods in the COVID19DataRetrieval class have been reorganized by level of specificity (less specific to more specific) in terms of the details given by the user and the details returned by the SUD as it pertains to the COVID19 case data
  • Added additional comments that specify some of the changes made to the code vs the original
  • Added additional comments further detailing the functions of each of the methods
  • Changed the accessibility settings on various variables and methods for functional and precautionary reasons
  • Reorganized and used comments to divide up sections of code and grouping up for possible further aggregation

Further details regarding this pull request will be stated in the report.

@Zy8712 Zy8712 changed the title Inserted comments and made minor changes Aggregation Pull Request #1 Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant