Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update blbe_encounter.json #1438

Merged
merged 9 commits into from
Jan 9, 2025
Merged

Conversation

somethingtemporaryarkham
Copy link
Contributor

Added the rest of the Blob That Ate Everything Else encounter cards.

@somethingtemporaryarkham
Copy link
Contributor Author

@fspoettel @drawntotheflame Pinging for review of the Blob That Ate Everything Else encounter cards that I added.

Copy link
Contributor

@drawntotheflame drawntotheflame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @somethingtemporaryarkham - I think you did a really thorough effort on the story cards and all the changing details on the aberrations.
I've suggested some tidy-ups, mainly with spacing or formatting, and a few times where the code/encounter position/position needed correcting, but otherwise, terrific work! Thank you.

pack/side/blbe_encounter.json Outdated Show resolved Hide resolved
pack/side/blbe_encounter.json Outdated Show resolved Hide resolved
pack/side/blbe_encounter.json Outdated Show resolved Hide resolved
pack/side/blbe_encounter.json Outdated Show resolved Hide resolved
pack/side/blbe_encounter.json Outdated Show resolved Hide resolved
pack/side/blbe_encounter.json Outdated Show resolved Hide resolved
pack/side/blbe_encounter.json Outdated Show resolved Hide resolved
pack/side/blbe_encounter.json Outdated Show resolved Hide resolved
{
"code": "89017",
"encounter_code": "migo_incursion_2",
"encounter_position": 9,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"encounter_position": 9,
"encounter_position": 8,

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We go with the lower number for encounter position if given a choice.

pack/side/blbe_encounter.json Outdated Show resolved Hide resolved
"clues": 2,
"code": "89001",
"double_sided": true,
"encounter_code": "blbe",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This encounter code does not exist, so the set cannot be imported into the database. There is an existing set blob_that_ate_everything_else that we can use here.

pack/side/blbe_encounter.json Outdated Show resolved Hide resolved
pack/side/blbe_encounter.json Outdated Show resolved Hide resolved
pack/side/blbe_encounter.json Outdated Show resolved Hide resolved
pack/side/blbe_encounter.json Outdated Show resolved Hide resolved
pack/side/blbe_encounter.json Outdated Show resolved Hide resolved
pack/side/blbe_encounter.json Outdated Show resolved Hide resolved
pack/side/blbe_encounter.json Outdated Show resolved Hide resolved
pack/side/blbe_encounter.json Outdated Show resolved Hide resolved
pack/side/blbe_encounter.json Outdated Show resolved Hide resolved
pack/side/blbe_encounter.json Outdated Show resolved Hide resolved
@somethingtemporaryarkham
Copy link
Contributor Author

@fspoettel @drawntotheflame Thanks for the formatting comments; I accepted the changes and removed the lines between the different cards. Let me know if there's anything else!

Copy link
Contributor

@fspoettel fspoettel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@somethingtemporaryarkham one more thing I noticed

pack/side/blbe_encounter.json Outdated Show resolved Hide resolved
pack/side/blbe_encounter.json Outdated Show resolved Hide resolved
@somethingtemporaryarkham
Copy link
Contributor Author

@fspoettel Done!

Copy link
Contributor

@fspoettel fspoettel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. cc @zzorba @drawntotheflame for final approval

@zzorba zzorba merged commit 25e0cfa into Kamalisk:master Jan 9, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants