-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update blbe_encounter.json #1438
Conversation
@fspoettel @drawntotheflame Pinging for review of the Blob That Ate Everything Else encounter cards that I added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, @somethingtemporaryarkham - I think you did a really thorough effort on the story cards and all the changing details on the aberrations.
I've suggested some tidy-ups, mainly with spacing or formatting, and a few times where the code/encounter position/position needed correcting, but otherwise, terrific work! Thank you.
pack/side/blbe_encounter.json
Outdated
{ | ||
"code": "89017", | ||
"encounter_code": "migo_incursion_2", | ||
"encounter_position": 9, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"encounter_position": 9, | |
"encounter_position": 8, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We go with the lower number for encounter position if given a choice.
pack/side/blbe_encounter.json
Outdated
"clues": 2, | ||
"code": "89001", | ||
"double_sided": true, | ||
"encounter_code": "blbe", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This encounter code does not exist, so the set cannot be imported into the database. There is an existing set blob_that_ate_everything_else
that we can use here.
Co-authored-by: drawntotheflame <[email protected]>
Co-authored-by: drawntotheflame <[email protected]>
Co-authored-by: drawntotheflame <[email protected]>
Co-authored-by: drawntotheflame <[email protected]>
Co-authored-by: drawntotheflame <[email protected]>
@fspoettel @drawntotheflame Thanks for the formatting comments; I accepted the changes and removed the lines between the different cards. Let me know if there's anything else! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@somethingtemporaryarkham one more thing I noticed
Co-authored-by: Felix Spöttel <[email protected]>
Co-authored-by: Felix Spöttel <[email protected]>
@fspoettel Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. cc @zzorba @drawntotheflame for final approval
Added the rest of the Blob That Ate Everything Else encounter cards.