Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FHV Player Cards #1348

Merged
merged 20 commits into from
Feb 17, 2024
Merged

FHV Player Cards #1348

merged 20 commits into from
Feb 17, 2024

Conversation

zzorba
Copy link
Collaborator

@zzorba zzorba commented Jan 30, 2024

All FHV cards are present now and have been reviewed by @5argon.

The state release date is confusing, but FFG said in their livestream that it was Feb 16, 2024

@zzorba zzorba changed the title Guardian and some mystic cards from FHV Leaked cards from FHV Feb 1, 2024
@Hounk
Copy link
Contributor

Hounk commented Feb 9, 2024

I was checking, if some cards were still missing and found out, the data is completed. However, by skimming over the code, I noticed a typo: "Dawn Star" is on position 131, not 132.

@5argon
Copy link
Contributor

5argon commented Feb 11, 2024

@zzorba I opened PR on your branch with some more edits

Daniel Salinas and others added 15 commits February 11, 2024 09:57
Some corrections :
- Dawn Star : Should be 1 wild icon.
- Rod of Carnamagos (2) : Quantity should be 2.
- Olive McBride (2) : Should be 2 willpower icons.
Should be 1 agility
There is one copy of each
- Seal of the Elders : 1 combat, not 2
- Dark Horse : No icon
- Dark Horse : Remove duplicate text
pack/fhv/fhvp.json Outdated Show resolved Hide resolved
Co-authored-by: Felix Spöttel <[email protected]>
pack/fhv/fhvp.json Outdated Show resolved Hide resolved
pack/fhv/fhvp.json Outdated Show resolved Hide resolved
pack/fhv/fhvp.json Outdated Show resolved Hide resolved
@@ -226,6 +226,7 @@
"sanity": 1,
"skill_agility": 1,
"slot": "Body",
"tags": "pa.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was it cleared up whether the parley access is limited to Parley. actions or does it also apply to cards like this?

In this specific case, it does not make a functional difference though as Neutral 0-5 grants access anyway.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe I got a clarification that it applies to parley generally -- though not on a card like Grizzled (which has Parley in italics as a rule reminder)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I know though, it doesn't actually matter yet (all the cards that mention parley are already rogue IIRC)

@robert-huang
Copy link
Contributor

very minor typo, i opened a pr to your branch zzorba#4

@zzorba zzorba changed the title Leaked cards from FHV FHV Player Cards Feb 17, 2024
@zzorba
Copy link
Collaborator Author

zzorba commented Feb 17, 2024

The announcement article has been posted, so these cards are now all officially out.

@Kamalisk Kamalisk merged commit c002d2a into Kamalisk:master Feb 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants