Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sense_resistor description #524

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

Zeanon
Copy link
Member

@Zeanon Zeanon commented Jan 6, 2025

Specifying the sense resistor as "motor" dependant confuses people as it is a driver spec, not a motor spec.

Checklist

  • pr title makes sense
  • squashed to 1 commit
  • added a test case if possible
  • if new feature, added to the readme
  • ci is happy and green

Specifying the sense resistor as "motor" dependant confuses people as it is a driver spec, not a motor spec.
@Zeanon Zeanon requested a review from a team as a code owner January 6, 2025 17:26
@rogerlz rogerlz merged commit 1eb5214 into main Jan 7, 2025
3 checks passed
@rogerlz rogerlz deleted the documentation/fix_sense_resistor_description branch January 7, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants