Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement rehome_z for z_tilt/qgl #494

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Zeanon
Copy link
Contributor

@Zeanon Zeanon commented Dec 19, 2024

Added rehome_z parameter to z_tilt, z_tilt_ng and qgl to automatically rehome z after leveling the bed/gantry
Also removed boilerplate code as ZAdjustStatus in z_tilt and z_tilt_ng was the same in both

Checklist

  • pr title makes sense
  • squashed to 1 commit
  • added a test case if possible
  • if new feature, added to the readme
  • ci is happy and green

@Zeanon Zeanon requested a review from a team as a code owner December 19, 2024 14:02
@@ -1444,6 +1444,9 @@ extended [G-Code command](G-Codes.md#z_tilt) becomes available.
#increasing_threshold: 0.0000001
# Sets the threshold that probe points can increase before z_tilt aborts.
# To disable the validation, set this parameter to a high value.
#rehome_z: False
# If set to true, a G28 Z will automatically be called after z_tilt has
# finished to rehome Z.
Copy link
Contributor

@rogerlz rogerlz Dec 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If set to True, execute G28 Z after z_tilt is applied. Defaults to False.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will modify

@rogerlz
Copy link
Contributor

rogerlz commented Dec 20, 2024

Looks good.. just a small suggestion on the text and it is good to go.

@rogerlz rogerlz force-pushed the home_z_after_z_tilt branch from 50b2621 to adab1d4 Compare December 20, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants