Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for LIS3DH #492

Merged
merged 4 commits into from
Dec 23, 2024
Merged

Support for LIS3DH #492

merged 4 commits into from
Dec 23, 2024

Conversation

Wulfsta
Copy link
Contributor

@Wulfsta Wulfsta commented Dec 19, 2024

This adds support for the LIS3DH, see #6715 on Klipper. I haven't squashed these, but can if requested. As implied by the content of these commits, this targets supporting the accelerometer on the Duet3D 1LC.

Checklist

  • pr title makes sense
  • squashed to 1 commit
  • added a test case if possible
  • if new feature, added to the readme
  • ci is happy and green

@Wulfsta Wulfsta requested a review from a team as a code owner December 19, 2024 02:41
@rogerlz
Copy link
Contributor

rogerlz commented Dec 20, 2024

Thanks, It looks good to me.. do we have anyone running Kalico that can test with the hardware?

@Wulfsta
Copy link
Contributor Author

Wulfsta commented Dec 20, 2024

Thanks, It looks good to me.. do we have anyone running Kalico that can test with the hardware?

I can switch over and try it out, but won’t have time for a few weeks. The only change from the klipper PR is ruff formatting, if that alleviates some worry. @eamaclean do you happen to have time to test this on a 1LC?

@rogerlz rogerlz merged commit 2ad3338 into KalicoCrew:main Dec 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants