driver_cs has been added to tmc5160

[HonestBrothers]

Previously, CS (current scaler) has been automatically set to 31. The only time CS would only change was to adjust the holding_current. However, some users found certain motor, driver, and voltage combinations to produce less than ideal results on tmc5160 drivers. Noise, VFA's and overheating were a common occurrence, particularly on high amp drivers and high power motors.

According to the excel spreadsheet provided by Trinamic to tune the 5160 tmc drivers, the CS value should be set so that Rsense on the spreadsheet matches the 'sense_resistor' value as defined in printer.cfg. By adjusting the CS value so that these two match, we can define much more adequate hysteresis values. This means that high power motors can now be run at high voltage (>48V) and their current may be run at RMS value without overheating.

[CarVac]

What are those .idea files? I think they need to be removed.

Also, the config_changes needs tweaking. CS doesn't necessarily have to be set based on current as calculated by TMC5160_calcs, it can be that value or higher (since globalscaler is still available to reduce the run current.

[HonestBrothers]

What are those .idea files? I think they need to be removed.

PyCharm bloat. I'll remove them.

Also, the config_changes needs tweaking. CS doesn't necessarily have to be set based on current as calculated by TMC5160_calcs, it can be that value or higher (since globalscaler is still available to reduce the run current.

Correct, working on an error if it's lower to where the target current can't be reached.

[HonestBrothers]

I also made an update to 2130
I implemented math.ceil for cs here:

       cs = (math.ceil(
            int(32.0 * sense_resistor * current * math.sqrt(2.0) / vref)
            - 1
        ))

instead of the default behavior where 0.5 gets added to vref:

            cs = (
                int(32.0 * sense_resistor * current * math.sqrt(2.0) / vref + 0.5)
                - 1
            )

I'm not sure why 0.5 was being added other than rounding. It's not in the datasheets.

[HonestBrothers]

@rogerlz

In tmc.py can we change:

        self.config_hold_current = config.getfloat(
            "hold_current", max_current, above=0.0, maxval=max_current
        )

to:

        self.config_hold_current = config.getfloat(
            "hold_current", run_current, above=0.0, maxval=max_current
        )

or would that break things?

[CarVac]

Make sure to fix the "xlxs" typo in the GLOBALSCALER_ERROR (line 265 in tmc5160.py)

[agravelot]

related to Klipper3d/klipper#6644