-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
homing: allow homing_accel to be configurable #474
base: main
Are you sure you want to change the base?
Conversation
self._reset_endstop_states(endstops) | ||
|
||
hmove.homing_move(homepos, hi.speed) | ||
try: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason for the try/finally here?
since we dont catch any errors we are going into estop if one occurs so no need for the finally right?
Also wouldnt it be cleaner to use with
instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to make sure that homing_accel always resets regardless of the deeper exceptions
This might not be the ideal place to discuss this issue, but it would be beneficial to have the ability to overwrite TMC driver parameters for homing. Specifically, the LDO 2804 drivers require fairly aggressive settings to achieve decent performance. However, these settings generate significant noise during homing, making consistent stall detection quite challenging. I suggest adding a homing options to configure the following parameters: driver_TBL, driver_TOFF, driver_HSTRT, driver_HEND, and driver_TPFD. |
I suggest opening a feature request on discord or github issue to track this.. thanks |
Untested, depends on #472
As suggested in #395
I also took the opportunity to rename
_set_current_homing
to_set_homing_current
to match the new method added and make it more readable.