Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

homing: allow homing_accel to be configurable #474

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

rogerlz
Copy link
Contributor

@rogerlz rogerlz commented Dec 10, 2024

Untested, depends on #472

As suggested in #395

I also took the opportunity to rename _set_current_homing to _set_homing_current to match the new method added and make it more readable.

klippy/stepper.py Outdated Show resolved Hide resolved
self._reset_endstop_states(endstops)

hmove.homing_move(homepos, hi.speed)
try:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason for the try/finally here?
since we dont catch any errors we are going into estop if one occurs so no need for the finally right?

Also wouldnt it be cleaner to use with instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to make sure that homing_accel always resets regardless of the deeper exceptions

@MSzturc
Copy link

MSzturc commented Dec 18, 2024

This might not be the ideal place to discuss this issue, but it would be beneficial to have the ability to overwrite TMC driver parameters for homing. Specifically, the LDO 2804 drivers require fairly aggressive settings to achieve decent performance. However, these settings generate significant noise during homing, making consistent stall detection quite challenging.

I suggest adding a homing options to configure the following parameters: driver_TBL, driver_TOFF, driver_HSTRT, driver_HEND, and driver_TPFD.

@rogerlz
Copy link
Contributor Author

rogerlz commented Dec 23, 2024

This might not be the ideal place to discuss this issue, but it would be beneficial to have the ability to overwrite TMC driver parameters for homing. Specifically, the LDO 2804 drivers require fairly aggressive settings to achieve decent performance. However, these settings generate significant noise during homing, making consistent stall detection quite challenging.

I suggest adding a homing options to configure the following parameters: driver_TBL, driver_TOFF, driver_HSTRT, driver_HEND, and driver_TPFD.

I suggest opening a feature request on discord or github issue to track this.. thanks

@rogerlz rogerlz marked this pull request as ready for review December 23, 2024 02:06
@rogerlz rogerlz requested a review from a team as a code owner December 23, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants