temperature_fan: Improved code quality of fan curve and fixed hysteresis #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NokkOnEffect
force-pushed
the
main
branch
5 times, most recently
from
f67ca92 to
cc34fa5
Compare
|
I was able to test it now and as far as I can tell everything works fine.
|
rogerlz
requested changes
Dec 10, 2024
Zeanon
suggested changes
Dec 11, 2024
NokkOnEffect
force-pushed
the
main
branch
2 times, most recently
from
8e92503 to
367cd85
Compare
Zeanon
approved these changes
Dec 13, 2024
fixed errors and extended curve Fixed hysteresis, extended curve and improved code quality fix incorrect curve extension removed controlled_fan, deprecated setting update docs removed deprecated param from tests make ruff happy
rogerlz
approved these changes
Dec 23, 2024
rogerlz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains improvements to the code quality of the
ControlCurveclass to improve readability. Furthermore unnecessary operations were removed.The current behaviour of the hysteresis when using a fan curve for control is incorrect and causes intermittent jumps between fixed pwm values without following the curve or reaching either end of the curve. This pull request contains an improved implementation.
Please be aware that this requests testing is limited as I'm currently not able to validate the behaviour in a live environment! I am open to feedback.
Checklist
added a test case if possible