disable heaters if a specified mcu is connected #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogerlz
requested changes
Nov 22, 2024
rogerlz
requested changes
Dec 10, 2024
README.md
Outdated
| @@ -126,6 +126,8 @@ See the [Danger Features document](https://dangerklipper.io/Danger_Features.html | |||
|
|
|||
| - [danger_options: configurable homing constants](https://github.com/DangerKlippers/danger-klipper/pull/378) | |||
|
|
|||
| - [adxl: disable heaters when connected](https://github.com/DangerKlippers/danger-klipper/pull/425) | |||
There was a problem hiding this comment.
the message needs improving
docs/Config_Reference.md
Outdated
| @@ -1091,7 +1091,9 @@ per_move_pressure_advance: False | |||
| # If true, uses pressure advance constant from trapq when processing moves | |||
| # This causes changes to pressure advance be taken into account immediately, | |||
| # for all moves in the current queue, rather than ~250ms later once the queue gets flushed | |||
|
|
|||
| #disable_if_connected: | |||
| # List of mcus that should disable the heater if connected, usefull for nozzle adxls | |||
klippy/extras/heaters.py
Outdated
| @@ -61,6 +61,11 @@ def __init__(self, config, sensor): | |||
| self.printer.get_start_args().get("debugoutput") is not None | |||
| ) | |||
| self.can_extrude = self.min_extrude_temp <= 0.0 or is_fileoutput | |||
| self.disable_if_connected = [] | |||
| if hasattr(config, "getlist"): | |||
There was a problem hiding this comment.
Cause some dummy configs don't have that attribute and I ran into issues without it in the older version
Probably not needed anymore since we are now checking in heaters and not adxl
rogerlz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #424
Checklist