Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

noncritical mcus #42

Merged
merged 1 commit into from
Jan 31, 2024
Merged

noncritical mcus #42

merged 1 commit into from
Jan 31, 2024

Conversation

bwnance
Copy link
Contributor

@bwnance bwnance commented Aug 11, 2023

add support for hotplugging mcus

@dalegaard
Copy link
Contributor

dalegaard commented Sep 11, 2023

Hi,

Just some thoughts, feel free to ignore. It would be useful, if instead of marking MCUs as non-critical, functions using each MCU mark them as critical. E.g. an active stepper will mark the MCU it's connected to as critical, an active ADXL, a bed leveling sensor, etc. This way, the user doesn't need to configure anything and the system automatically figures out what is and isn't critical. Obviously the main MCU will always be critical, as it's the timing master, but all other MCUs could start out non-critical.

Basically a reference counting kind of system.

Best regards,
Lasse

@bwnance
Copy link
Contributor Author

bwnance commented Sep 11, 2023

@dalegaard I really like that idea. I'd have to noodle on it a little bit regarding the disconnect/reconnect states - I'd be worried that an on-demand init/release of an MCU would induce too much overhead

@bwnance bwnance force-pushed the noncritical_mcus_pr branch from b939ded to 55ac128 Compare November 5, 2023 16:03
@bwnance bwnance changed the base branch from master to bleeding-edge November 5, 2023 16:06
@bwnance bwnance force-pushed the noncritical_mcus_pr branch from 55ac128 to 53d1b1b Compare January 5, 2024 18:06
@rogerlz rogerlz force-pushed the noncritical_mcus_pr branch from 53d1b1b to 3176116 Compare January 29, 2024 22:32
@rogerlz rogerlz force-pushed the noncritical_mcus_pr branch from 3176116 to 669f8b1 Compare January 31, 2024 15:30
@rogerlz rogerlz merged commit a471b2b into bleeding-edge Jan 31, 2024
2 checks passed
@rogerlz rogerlz deleted the noncritical_mcus_pr branch January 31, 2024 15:34
rogerlz pushed a commit that referenced this pull request May 19, 2024
rogerlz pushed a commit that referenced this pull request May 21, 2024
rogerlz pushed a commit that referenced this pull request May 22, 2024
rogerlz pushed a commit that referenced this pull request May 28, 2024
rogerlz pushed a commit that referenced this pull request Jun 4, 2024
rogerlz pushed a commit that referenced this pull request Jun 4, 2024
rogerlz pushed a commit that referenced this pull request Jun 4, 2024
kageurufu pushed a commit to kageurufu/danger-klipper that referenced this pull request Jun 15, 2024
bwnance added a commit that referenced this pull request Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants