Dual loop pid #118
Dual loop pid #118
Conversation
rogerlz
force-pushed
the
master-danger
branch
3 times, most recently
from
f5d3460 to
240edcf
Compare
rogerlz
force-pushed
the
master-danger
branch
2 times, most recently
from
2346081 to
6968f00
Compare
|
Might it be better called "cascade PID" to match standard terminology? |
Cascade PID is different from this one, it involves a hierarchical arrangement where one PID loop sets the setpoint for another. In this case we have two parallel pid's and the final signal its a minimum value between both. |
|
Ah, I see. Never mind then. |
|
Still seems to break pid_v (however I'm on the bleeding edge branch so might be some changes there). Setting extruder control to pid_v results in a 0 degrees reading and no heating. No other issues, smooth control even with a 12kg thermal mass. |
Merge modifications from pid_v feature Signed-off-by: Rodrigo Andrade <[email protected]>
Merge modifications from pid_v feature Signed-off-by: Rodrigo Andrade <[email protected]>
Update docs with dual_loop_pid params Signed-off-by: Rodrigo Andrade <[email protected]>
added reference from the implemented feature Signed-off-by: Rodrigo Andrade <[email protected]>
Apply the tolerance logic for the primary controller calibration Signed-off-by: Rodrigo Andrade <[email protected]>
rogerlz
force-pushed
the
master-danger
branch
from
6968f00 to
6784959
Compare
|
I am testing this PR this week |
|
i can really see the benefit of this used in a " active chamber" ! . |
|
I get config wrapper errors trying to bring this into bleeding edge for testing, did bleeding edge even touch the heater's code? |
|
We seem to be having a weird GitHub bug that is auto-closing this PR |
|
virtual bullying |
|
Wtf is going on with this PR my email has been spammed periodically most of
the day
…On Wed, May 15, 2024, 7:13 PM Rogerio Goncalves ***@***.***> wrote:
Closed #118 <https://github.com/DangerKlippers/danger-klipper/pull/118>.
—
Reply to this email directly, view it on GitHub
<https://github.com/DangerKlippers/danger-klipper/pull/118#event-12825091381>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIM3Y3BKGJBHQR542FNOM2DZCP2Y7AVCNFSM6AAAAABBNRRTZWVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSHAZDKMBZGEZTQMI>
.
You are receiving this because you commented.Message ID:
***@***.***
com>
|
|
You're hitting a corner case in how GitHub PRs work. It looks like this repo is no longer a fork of Klipper, it's a separate repo. This PR was opened before that, when rodrigo2019's repo and this repo were both forks of Klipper. When this repo was disconnected the PR was automatically closed, GitHub can't handle PRs between repos that aren't in the same network anymore. There is no way to fix this PR, a new one will need to be opened from a fork of danger-klipper. |
upstream: Klipper3d/klipper#5972
got some @rogerlz implementation from https://github.com/DangerKlippers/danger-klipper/pull/58 and fixed merge issues with the pid_v features