feat: order force withdrawal #110
Conversation
Vovke
force-pushed
the
force-withdrawal
branch
from
bf35056 to
581d0a3
Compare
@fluiderson that part still WIP, way more work than expected |
Vovke
force-pushed
the
force-withdrawal
branch
3 times, most recently
from
5db1f32 to
0f6998a
Compare
Vovke
force-pushed
the
force-withdrawal
branch
from
0f6998a to
fa3d853
Compare
Co-authored-by: Vova Lando <[email protected]>
|
linking issue for upper tx limit |
src/chain/tracker.rs
Outdated
| if let Some(native_token) = &chain.native_token { | ||
| (native_token.name == *name) && (native_token.decimals == specs.decimals) | ||
| } else { | ||
| assets = assets |
There was a problem hiding this comment.
why replace smart retain and any with primitives?
There was a problem hiding this comment.
@Slesarew, this code takes names for assets from the config, not from a chain. The retain method doesn't allow the mutating of the key value, hence filter_map and then collect.
There was a problem hiding this comment.
and why not from the chain? Taking those from chain ensures they will be accepted by chain and things will match as advertised, does it not?
There was a problem hiding this comment.
wait. Aren't these two doing exactly same thing?
There was a problem hiding this comment.
and why not from the chain? Taking those from chain ensures they will be accepted by chain and things will match as advertised, does it not?
Basically, I just removed checks for asset names from your code. Everything else is the same.
There was a problem hiding this comment.
If you don't get why, there's no such thing as an asset name for the Assets pallet in terms of the asset transferring, just IDs. Names are just a metadata for humans there. Now, the daemon user can set the same asset names as on the chain or name them on their own (with the checks, this was impossible). The latter feature was very much requested for testing purposes by the frontend team.
Vovke
force-pushed
the
force-withdrawal
branch
from
307fde6 to
5d1ab46
Compare
No description provided.