Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should have additional field in order, repaid_amount #87

Open
Vovke opened this issue Oct 16, 2024 · 1 comment
Open

We should have additional field in order, repaid_amount #87

Vovke opened this issue Oct 16, 2024 · 1 comment
Labels
p2🚙 Mid priority, needed but can wait question Further information is requested

Comments

@Vovke
Copy link
Collaborator

Vovke commented Oct 16, 2024

We need repaid_amount field as part of the order structure in order to easily understand how much was repaid already. Main case is when the order is repaid in chunks, we can calculate repaid amount using transactions, but that means we want frontend to calculate it for us which is potential for mistakes.

There are 2 options for implementation,

  • we update repaid_amount with each transaction happening and store it in the database among other order fields
  • we calculate repaid_amount based on the sum of transactions
@Vovke Vovke added question Further information is requested p2🚙 Mid priority, needed but can wait labels Oct 16, 2024
@Vovke
Copy link
Collaborator Author

Vovke commented Oct 23, 2024

based on #77 we update repaid_amount with each order's incoming transaction.

ensure that this change reflected in:

@Vovke Vovke added this to Kalatori Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2🚙 Mid priority, needed but can wait question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant