Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle overpayment #77

Open
Vovke opened this issue Oct 9, 2024 · 1 comment
Open

Handle overpayment #77

Vovke opened this issue Oct 9, 2024 · 1 comment
Labels
enhancement New feature or request p3🚲 Low priority, we do want to do it, but only if there is nothing else to do question Further information is requested
Milestone

Comments

@Vovke
Copy link
Collaborator

Vovke commented Oct 9, 2024

No description provided.

@Vovke Vovke added the enhancement New feature or request label Oct 10, 2024
@Vovke Vovke added p2🚙 Mid priority, needed but can wait question Further information is requested labels Oct 23, 2024
@Vovke
Copy link
Collaborator Author

Vovke commented Oct 23, 2024

We can track overpayment by implementing #87, that way we could track amount repaid on our side instead of fetching transactions from chain and doing ∑(transaction.amount)-amount >= 0 (we should not rely on chain being available for calculations like this one). Since we cannot prevent users from overpaying, the repaid_amount field will be available as part of the order object. If repaid_amount exceeds amount, the overpayment can be detected and managed accordingly.

We can add logic notifying the merchant about overpayment on the client side (as there is no merchant contact at Kalatori backend) in the future, or by having this information as part of the report or some other way.
cc: @Slesarew , @fluiderson , @kirushik

@Vovke Vovke added p3🚲 Low priority, we do want to do it, but only if there is nothing else to do and removed p2🚙 Mid priority, needed but can wait labels Oct 23, 2024
@Vovke Vovke added this to Kalatori Oct 31, 2024
@Vovke Vovke added this to the Milestone 2 milestone Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request p3🚲 Low priority, we do want to do it, but only if there is nothing else to do question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant