-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/385 #391
Open
devkyoung2
wants to merge
9
commits into
dev
Choose a base branch
from
feat/385
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feat/385 #391
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
5cb25aa
[feat]: 장바구니 개수 레이아웃 구현(#385)
devkyoung2 5e9f398
[feat]: 장바구니 카운트 조회 api 응답타입 작성(#385)
devkyoung2 ba69901
[feat]: 장바구니 카운트 조회 api 요청 함수작성(#385)
devkyoung2 f708ec6
Merge branch 'dev' into feat/385
devkyoung2 d7790da
[refactor]: 장바구니 카운트 조회 api 요청함수/응답타입 수정(#385)
devkyoung2 b776b92
[feat]: 장바구니 개수 카운팅 구현(#385)
devkyoung2 bf8a200
[feat]: 장바구니 추가/삭제시 캐시 무효화(#385)
devkyoung2 5c6edb9
[fix]: 장바구니 삭제 클릭시 이벤트 전파 막음(#385)
devkyoung2 fb3c1f5
[feat]: 체크박스/삭제 아이콘 오버시 포인터 기능 추가(#385)
devkyoung2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,3 +14,5 @@ export type CartItem = { | |
}; | ||
|
||
export type CartResponse = CartItem[]; | ||
|
||
export type CartCountResponse = number; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cartCount! > 0
요 조건이 있는데,cartCount
가 non-null로 단언이 되어 있는 것 같아요.cartCount
는 API 응답인데 이렇게 단언해도 되나요??There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
!isLoading
에서 이미false
를 리턴하니까cartCount
가null
값일 수가 없어요. 만약 API 요청에서 에러가 발생해 에러핸들링하는 경우를 말씀하시는거라면 이 컴포넌트가 아니라 인터셉트에서 핸들링하는게 낫지 않을까요?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아하 그렇겠네요 이해했습니다 !