Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat]: 장바구니 상품 삭제 api 연동(#357) #371

Merged
merged 2 commits into from
Jun 18, 2024
Merged

Conversation

devkyoung2
Copy link
Member

#️⃣연관된 이슈

close: #357

📝작업 내용

  • 장바구니 상품 삭제 API 연동

🙏리뷰 요구사항(선택)

  • 356에서 갈라진 브랜치라서 356이 병합되면 dev로 병합하겠습니다.
  • 삭제 요청이 정상적으로 작동은 되지만 UX가 상당히 이상해요 ㅠ 왜냐면 선택된 상품데이터는 장바구니 상품 정보랑 별개로 프론트에서 관리되고 있기 때문에 상품이 삭제됐을때 선택된 상품데이터 체크 로직이 수행되면서 조금 부자연스럽게 동작해요. api가 변경되면 고쳐질 것같습니다.

@devkyoung2 devkyoung2 self-assigned this Jun 18, 2024
Copy link

vercel bot commented Jun 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kakao-funding ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 18, 2024 10:26am

Copy link
Contributor

@uraflower uraflower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

로직이 뭔가 다른 로직과 꼬여 있는 것처럼 보이는데, 뭐가 문제인지 알 것 같으면서도 명확하게 짚어내기가 어렵네요..
일단은 진행하죠..! 수고하셨습니다!

@devkyoung2 devkyoung2 changed the base branch from feat/356 to dev June 18, 2024 10:22
@devkyoung2 devkyoung2 merged commit b6ff9c3 into dev Jun 18, 2024
3 checks passed
@devkyoung2 devkyoung2 deleted the feat/357 branch June 18, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

장바구니 삭제 API 연동
3 participants