Feat/334 #353
Merged
Feat/334 #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 위시여부 및 위시카운트 추가
- 위시 요청 성공시 productDescription에 캐싱된 데이터를 무효화 시켜 다시 데이터를 fetch함
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ohgus
reviewed
Jun 8, 2024
Comment on lines
149
to
150
| useEffect(() => {}, [wish]); | ||
|
|
There was a problem hiding this comment.
위시 상품이 변경되면 재렌더링을 하기 위한 건가요??
There was a problem hiding this comment.
저도 궁금합니다! 어떤 코드인지 잘 모르겠습니다
There was a problem hiding this comment.
이 코드 의미 없는 코드인데 제가 지우는것을 깜빡한것같아요 제거했습니다! b7b4000
uraflower
approved these changes
Jun 8, 2024
Comment on lines
43
to
44
| wish, | ||
| } = productDescription; |
There was a problem hiding this comment.
wish가 위시 여부를 의미하는 건가요?
그렇다면 isWished나 wished처럼 이름을 짓는 건 어떨까용?
- wish => isWish
ohgus
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
close: #334
📝작업 내용
🙏리뷰 요구사항(선택)