[feat]: 주문내역 등록 날짜 추가(#346) #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ohgus
approved these changes
Jun 8, 2024
uraflower
approved these changes
Jun 8, 2024
Comment on lines
8
to
12
| .num_data { | ||
| @include font(15px, 700); | ||
|
|
||
| margin-left: 5px; | ||
| } |
There was a problem hiding this comment.
이게 실질적인 날짜값인 것 같은데 혹시 date를 data로 잘못 쓰신 건가요??
There was a problem hiding this comment.
헉 그러네요... 수정했습니다 .0c6e946
src/utils/format.ts
Outdated
| export const formatDateAndTime = (dateTime: string) => { | ||
| const [date, time] = dateTime.split('T'); | ||
|
|
||
| const formattedDate = date.split('-').join('.'); |
There was a problem hiding this comment.
replaceAll()로 대체 가능할 것 같습니당
| const [date, time] = dateTime.split('T'); | ||
|
|
||
| const formattedDate = date.split('-').join('.'); | ||
| const formattedTime = time.slice(0, 8); |
There was a problem hiding this comment.
작성하신 주석에 따르면 time은 hh:mm:ss인데 슬라이스하는 이유가 뭔가요?
다른 문자가 딸려 올까봐 하는 건가요?
There was a problem hiding this comment.
넵 주문내역 api 응답값으로 알수없는 숫자값이 딸려오더라구요 그래서 포매팅 해줬습니다.
- data -> date
- replaceAll 메서드를 사용하여 직관적으로 포매팅 함
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
close: #346
📝작업 내용
🙏리뷰 요구사항(선택)