Feat/227 #337
Merged
Feat/227 #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 기존 사용가능한 펀딩/사용한 펀딩 두개로 나누었던 탭을 하나로 합치면서 해당 파일들을 삭제함
- 기존 : date - 변경 : receivedDate
- 탭모드를 추가하여 펀딩함과 선물함에 여백을 추가함
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
uraflower
approved these changes
Jun 1, 2024
Comment on lines
40
to
42
| export const NotUsedGift: Story = { | ||
| args: { fundingItem }, | ||
| }; |
There was a problem hiding this comment.
스토리이름이 FundingItem이 아니라 Gift로 되어 있어요
There was a problem hiding this comment.
어이쿠 코드 옮겨오다가 놓쳤나봐요 수정했습니다. ee51e31
src/utils/generate.ts
Outdated
Comment on lines
6
to
14
| if (date) { | ||
| const currentDate = new Date(date); | ||
| const oneYearLaterDate = new Date( | ||
| currentDate.getFullYear() + 1, | ||
| currentDate.getMonth(), | ||
| currentDate.getDate(), | ||
| ); | ||
| return oneYearLaterDate; | ||
| } |
There was a problem hiding this comment.
8-13 줄이 중복되는 것 같습니다. 아래처럼 리팩토링하는 건 어떨까요?
const getOneYearLaterDate = (date?: string) => {
const currentDate = date ? new Date(date) : new Date();
const oneYearLaterDate = new Date(
currentDate.getFullYear() + 1,
currentDate.getMonth(),
currentDate.getDate(),
);
return oneYearLaterDate;
}
ohgus
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
close: #227 #228
📝작업 내용
🙏리뷰 요구사항(선택)