-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
펀딩 아이템 추가, 조회 구현 및 상품 상세정보 조회기능 리팩토링 #58
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmw2378
reviewed
Mar 22, 2024
src/main/java/org/kakaoshare/backend/domain/funding/controller/FundingController.java
Outdated
Show resolved
Hide resolved
kmw2378
reviewed
Mar 22, 2024
kmw2378
reviewed
Mar 22, 2024
src/main/java/org/kakaoshare/backend/domain/funding/service/FundingService.java
Outdated
Show resolved
Hide resolved
kmw2378
approved these changes
Mar 22, 2024
YeaChan05
approved these changes
Mar 24, 2024
kmw2378
reviewed
Mar 24, 2024
src/main/java/org/kakaoshare/backend/domain/funding/dto/ProgressResponse.java
Show resolved
Hide resolved
kmw2378
reviewed
Mar 24, 2024
src/main/java/org/kakaoshare/backend/domain/funding/dto/ProgressResponse.java
Show resolved
Hide resolved
kmw2378
reviewed
Mar 24, 2024
src/main/java/org/kakaoshare/backend/domain/funding/dto/RegistrationResponse.java
Outdated
Show resolved
Hide resolved
YeaChan05
reviewed
Mar 24, 2024
kmw2378
approved these changes
Mar 24, 2024
kmw2378
approved these changes
Mar 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
close #47
📝작업 내용
✅테스트 결과
🙏리뷰 요구사항(선택)
상품 상세정보 조회기능에서 하나의 sql문에서 여러 join이 되지않아 각 필드별로 분리해서 조회한다음 추가하는 방식으로 했습니다. 더 좋은 방법이 있다면 알려주세요..