Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move InnerP to simulation_common and clean terminology #189

Merged
merged 5 commits into from
Nov 4, 2024

Conversation

keiyamamo
Copy link
Collaborator

Class InnerP was defined in several problem files, so decided to move it to simulation_common.py. At the same time, I cleaned up the terminology (now it is called InterfacePressure to be more specific).

@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 96.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.91%. Comparing base (b342bb3) to head (d34352b).
Report is 29 commits behind head on master.

Files with missing lines Patch % Lines
src/vasp/simulations/simulation_common.py 94.11% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #189      +/-   ##
==========================================
+ Coverage   78.73%   80.91%   +2.18%     
==========================================
  Files          32       31       -1     
  Lines        3743     3710      -33     
==========================================
+ Hits         2947     3002      +55     
+ Misses        796      708      -88     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@keiyamamo
Copy link
Collaborator Author

Hi @johannesring

I get an error from flake8

./src/vasp/simulations/offset_stenosis.py:9:1: F401 'turtleFSI.problems.*' imported but unused

but don’t really know what is the problem. I do the same import for aneurysm.py and other problem files, but only offset_stenosis.py with this PR gives this error. Do you have any idea how to fix this issue?
I could add # noqa: F401 and suppress this warning, but it would be nice not to do it.

Best,
Kei

@keiyamamo
Copy link
Collaborator Author

In addition to the previous change, I added some more changes.

  1. removed offset_stenosis_box.py. This problem was essentially the same as the original offset_stenosis.py with a different way of defining FSI region. I simply added a note inside offset_stenosis.py, explaining how to use a box for choosing FSI region.
  2. When reading Fourier coefficients, we previously used os.path, but switched to pathlib. This makes the code look cleaner.
  3. I had a problem with flake8 as above. Now the error is suppressed with # noqa: F401.

@keiyamamo keiyamamo merged commit 0b54e24 into KVSlab:master Nov 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants