feat: (#3) 스플래시 페이지 및 소셜 로그인 구현 #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
스플래시 화면 구현, 해당 과정에서 폰트적용이 안돼 폰트 적용 부분도 수정함
Closed
nebulaBdj
changed the title
1. 불필요한 import 정리 2. button type 속성 추가
로컬 환경에서 테스트 완료
추가적으로 로그인 페이지 SplashTop 위치도 수정
yeyounging
reviewed
Oct 27, 2024
src/app/auth/callback/page.tsx
Outdated
| } | ||
|
|
||
| const getUserData = async (socialType: string, sendDataArr: SendData[]) => { | ||
| let url: string = `https://cnergy.p-e.kr/v1/oauth/login/${socialType}?` |
There was a problem hiding this comment.
apiUrl은 환경변수로 따로 관리하는 게 더 좋을 것 같아요!
Comment on lines
3
to
22
| export const socialTypes: OauthBtnData[] = [ | ||
| { | ||
| id: 1, | ||
| type: 'kakao', | ||
| text: '카카오', | ||
| auth_uri: 'https://cnergy.p-e.kr/v1/oauth/kakao', | ||
| }, | ||
| { | ||
| id: 2, | ||
| type: 'naver', | ||
| text: '네이버', | ||
| auth_uri: 'https://cnergy.p-e.kr/v1/oauth/naver', | ||
| }, | ||
| { | ||
| id: 3, | ||
| type: 'google', | ||
| text: '구글', | ||
| auth_uri: 'https://cnergy.p-e.kr/v1/oauth/google', | ||
| }, | ||
| ] |
There was a problem hiding this comment.
auth_url은 생략가능할 것 같아요 !
There was a problem hiding this comment.
https://cnergy.p-e.kr/v1/oauth/는 고정하고 해당 객체읜 type을 https://cnergy.p-e.kr/v1/oauth/${type} 이렇게 넣자는 이야기 일까요??
| }, | ||
| fontFamily: { | ||
| pretendard: 'var(--pretendard)', | ||
| fontFamily: { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[해야할 작업]
[feat: 스플래시 페이지 구현 작업 세부내용]
[feat: 소셜로그인 구현 완료 작업 세부 내용]