Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xdma autogen C header #201

Merged
merged 5 commits into from
Jul 24, 2024
Merged

xdma autogen C header #201

merged 5 commits into from
Jul 24, 2024

Conversation

IveanEx
Copy link

@IveanEx IveanEx commented Jul 23, 2024

This PR adds the function to automatically generate C header for xdma's runtime when xdma hardware is generated and added into the snax cluster, as mentioned in Issue #200.

The generation of C header is entirely done in Scala (Chisel), so the consistency between hardware and software can always guaranteed. I suggest other chisel-generated buidling block also use this way, as there is no need to use two high-level programming languages to finish one task.

@IveanEx IveanEx requested a review from rgantonio July 23, 2024 15:58
Copy link

@rgantonio rgantonio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK!

But take out the .h file and make sure it's generated through CI properly first.

@rgantonio rgantonio added the clean up To keep repos clean label Jul 24, 2024
Copy link

@rgantonio rgantonio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine, if it cannot be fixed immediately, we need to make an issue that needs to clean up the software dependencies.

So we keep the header file first.

@IveanEx IveanEx removed the clean up To keep repos clean label Jul 24, 2024
@IveanEx IveanEx changed the title Ydeng/xdma autogen runtime xdma autogen C header Jul 24, 2024
@IveanEx IveanEx merged commit 289a9d5 into main Jul 24, 2024
27 checks passed
@IveanEx IveanEx deleted the ydeng/xdma_autogen_runtime branch July 24, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants