Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/#87/user space pay 관련 api customexception 적용 #94

Merged
merged 7 commits into from
Aug 14, 2024
Merged

Refactor/#87/user space pay 관련 api customexception 적용 #94

merged 7 commits into from
Aug 14, 2024

Conversation

seongjunnoh
Copy link
Collaborator

@seongjunnoh seongjunnoh commented Aug 13, 2024 •
edited
Loading

📝 요약

기존 exception class를 CustomException으로 변경 후, 제거하였습니다

이슈 번호 : #87

🔖 변경 사항

CustomException으로의 변경 뿐만아니라

  1. CustomExceptionControllerAdvice 의 BaseErrorResponse 생성 시 error 메시지를 포함하는 BaseErrorResponse가 생성될 수 있도록 코드를 수정하였습니다
    -> 이제 requestBody에서 jakartar 표준 validation과 BindingResult 를 이용해 걸러낸 에러메시지도 response에서 확인하실 수 있습니다

  2. 스페이스 생성 api의 response에 생성한 spaceId 추가

  3. 내가 요청받은 정산 조회 api의 response에 송금할 은행 정보 추가

또한 수정작업 진행하였습니다

아직 인터셉터에서의 UserSpace 인증 처리부분은 적용하지 못했습니다

✅ 리뷰 요구사항

📸 확인 방법 (선택)


📌 PR 진행 시 이러한 점들을 참고해 주세요

* P1 : 꼭 반영해 주세요 (Request Changes) - 이슈가 발생하거나 취약점이 발견되는 케이스 등
* P2 : 반영을 적극적으로 고려해 주시면 좋을 것 같아요 (Comment)
* P3 : 이런 방법도 있을 것 같아요~ 등의 사소한 의견입니다 (Chore)

@seongjunnoh seongjunnoh linked an issue Aug 13, 2024 that may be closed by this pull request
refactor : user, space, pay 관련 api CustomException 적용 #87
Closed
drbug2000
drbug2000 approved these changes Aug 13, 2024
View reviewed changes
Copy link
Collaborator

@drbug2000 drbug2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

구석구석 많이 수정해주셨네요. 고생하셨습니다

src/main/java/space/space_spring/exceptionHandler/CustomExceptionControllerAdvice.java
@@ -19,7 +19,7 @@ public class CustomExceptionControllerAdvice {
@ExceptionHandler(CustomException.class)
public ResponseEntity<BaseErrorResponse> handle_JwtBadRequestException(CustomException e) {
log.error("[handle_JwtBadRequestException]", e);
BaseErrorResponse errorResponse = new BaseErrorResponse(e.getExceptionStatus());
BaseErrorResponse errorResponse = new BaseErrorResponse(e.getExceptionStatus(), e.getMessage());
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 부분 잘 찾아 주셨네요! 좋습니다

@seongjunnoh seongjunnoh merged commit c4fc2a1 into develop Aug 14, 2024
3 checks passed
@hyunn522 hyunn522 deleted the refactor/#87/user-space-pay-관련-api-customexception-적용 branch August 14, 2024 14:40
seongjunnoh added a commit that referenced this pull request Oct 30, 2024
@seongjunnoh
Merge pull request #94 from KUIT-Space/refactor/#87/user-space-pay-관련…
12b767f 
…-api-customexception-적용

Refactor/#87/user space pay 관련 api customexception 적용
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drbug2000 drbug2000 drbug2000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor : user, space, pay 관련 api CustomException 적용
2 participants
@seongjunnoh @drbug2000