Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signup seongjunnoh #5

Merged
merged 21 commits into from
Jul 14, 2024
Merged

Signup seongjunnoh #5

merged 21 commits into from
Jul 14, 2024

Conversation

seongjunnoh
Copy link
Collaborator

๐Ÿ“ ์š”์•ฝ

์ด์Šˆ ๋ฒˆํ˜ธ : #๋ฒˆํ˜ธ

๐Ÿ”– ๋ณ€๊ฒฝ ์‚ฌํ•ญ

  1. ์›น ์ƒ์—์„œ ๋น ๋ฅธ db ํ…Œ์ŠคํŠธ๋ฅผ ์œ„ํ•ด h2 database ๋ฅผ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹น
    ์ด๋ฅผ ์œ„ํ•ด yml ํŒŒ์ผ์— ์šฐ์„  h2 database ๋ฅผ ์œ„ํ•œ ์„ค์ •์„ ์ถ”๊ฐ€ํ•ด๋†จ๋Š”๋ฐ, ํ˜น์‹œ mysql๋กœ ํ…Œ์ŠคํŠธ๋ฅด ์›ํ•˜์‹œ๋ฉด pull ๋ฐ›์œผ์‹ ํ›„ ์ถ”๊ฐ€ํ•ด์ฃผ์‹œ๋ฉด ๋  ๊ฑฐ ๊ฐ™์Šต๋‹ˆ๋‹ค
  2. rest api ๊ฐœ๋ฐœ์„ ์œ„ํ•ด response ํŒจํ‚ค์ง€๋ฅผ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค. ์ €ํฌ๊ฐ€ ์ฟ ์ž‡์—์„œ ๋ฏธ์…˜ํ• ๋•Œ ์‚ฌ์šฉํ–ˆ๋˜ ํŒจํ‚ค์ง€์™€ ๋™์ผํ•ฉ๋‹ˆ๋‹ค.
  3. ๊ฐœ๋ฐœ ๊ณ„์ธต ๊ตฌ์กฐ๋ฅผ ์œ„ํ•œ ํŒจํ‚ค์ง€๋ฅผ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค

์šฐ์„  ์ŠคํŽ˜์ด์Šค ์•ฑ์˜ ๊ณ ์œ  ํšŒ์›๊ฐ€์ž…/๋กœ๊ทธ์ธ ๊ธฐ๋Šฅ์„ ๊ฐœ๋ฐœํ•œ ํ›„, ์†Œ์…œ ๋กœ๊ทธ์ธ ๊ธฐ๋Šฅ์„ ๊ฐœ๋ฐœํ•˜๋ ค๊ณ  ํ•ฉ๋‹ˆ๋‹ค. ์ผ๋‹จ์€ ํ˜„์žฌ ๋‚˜์™€์žˆ๋Š” erd๋ฅผ ํ™•์ธํ•˜์—ฌ ์—”ํ‹ฐํ‹ฐ๋ฅผ ๋ฝ‘์•„ ๊ฐœ๋ฐœํ•˜์‹œ๋ฉด ๋ ๋“ฏํ•ฉ๋‹ˆ๋‹ค.
erd์—์„œ ๊ฐ ์—”ํ‹ฐํ‹ฐ๋“ค์„ ์ƒ์„ฑํ•˜๋Š” ์ฝ”๋“œ๋ฅผ ๊ณต์œ ํ•˜๊ฒ ๋‹ค๊ณ  ํ–ˆ์œผ๋‚˜, ์•„์ง erd๊ฐ€ ํ™•์ •๋œ๊ฒƒ์ด ์•„๋‹Œ๊ฑฐ๊ฐ™๊ธฐ๋„ ํ•˜๊ณ , ์ด ๋ถ€๋ถ„์€ ์ด๋ฒˆ์ฃผ ํšŒ์˜๋•Œ ๋‹ค๊ฐ™์ด ์–˜๊ธฐํ•ด์„œ ํ™•์ •ํ•˜๋ฉด ์ข‹์„๊ฑฐ๊ฐ™์Šต๋‹ˆ๋‹ค!

โœ… ๋ฆฌ๋ทฐ ์š”๊ตฌ์‚ฌํ•ญ

rest api ๊ฐœ๋ฐœ์„ ์œ„ํ•ด response ํŒจํ‚ค์ง€๋ฅผ ์ฟ ์ž‡ ๋ฏธ์…˜ ํŒŒ์ผ์—์„œ ๊ฐ€์ ธ์™”๋Š”๋ฐ, ํ˜น์‹œ ๋” ๋‚˜์€ ๋ฐฉ๋ฒ•์„ ์•Œ๊ณ ๊ณ„์‹  ๋ถ„์€ ๋ฆฌ๋ทฐํ•ด์ฃผ์‹œ๋ฉด ๊ฐ์‚ฌํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค!

๐Ÿ“ธ ํ™•์ธ ๋ฐฉ๋ฒ• (์„ ํƒ)



๐Ÿ“Œ PR ์ง„ํ–‰ ์‹œ ์ด๋Ÿฌํ•œ ์ ๋“ค์„ ์ฐธ๊ณ ํ•ด ์ฃผ์„ธ์š”

* P1 : ๊ผญ ๋ฐ˜์˜ํ•ด ์ฃผ์„ธ์š” (Request Changes) - ์ด์Šˆ๊ฐ€ ๋ฐœ์ƒํ•˜๊ฑฐ๋‚˜ ์ทจ์•ฝ์ ์ด ๋ฐœ๊ฒฌ๋˜๋Š” ์ผ€์ด์Šค ๋“ฑ
* P2 : ๋ฐ˜์˜์„ ์ ๊ทน์ ์œผ๋กœ ๊ณ ๋ คํ•ด ์ฃผ์‹œ๋ฉด ์ข‹์„ ๊ฒƒ ๊ฐ™์•„์š” (Comment)
* P3 : ์ด๋Ÿฐ ๋ฐฉ๋ฒ•๋„ ์žˆ์„ ๊ฒƒ ๊ฐ™์•„์š”~ ๋“ฑ์˜ ์‚ฌ์†Œํ•œ ์˜๊ฒฌ์ž…๋‹ˆ๋‹ค (Chore)

@seongjunnoh
Copy link
Collaborator Author

ํ…Œ์ŠคํŠธ ๋ถ€๋ถ„์—์„œ ์—๋Ÿฌ๊ฐ€ ๋‚œ๊ฑฐ๊ฐ™์€๋ฐ, ํ…Œ์ŠคํŠธ ๊ตฌํ˜„์ฒด๊ฐ€ ์—†์–ด์„œ ์—๋Ÿฌ๊ฐ€ ๋‚œ ๋“ฏํ•ด์„œ ๊ทธ๋ƒฅ ๋ฌด์‹œํ•ด๋„ ๋ ๋“ฏํ•ฉ๋‹ˆ๋‹น

Copy link
Member

@hyunn522 hyunn522 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@arkchive
Copy link
Collaborator

LGTM!

@seongjunnoh seongjunnoh merged commit ce6cb6a into main Jul 14, 2024
3 checks passed
@hyunn522 hyunn522 deleted the signup-seongjunnoh branch July 14, 2024 02:52
seongjunnoh added a commit that referenced this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants