Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/#163/participant service #168

Merged
merged 17 commits into from
Jan 9, 2025
Merged

Conversation

drbug2000
Copy link
Collaborator

@drbug2000 drbug2000 commented Nov 3, 2024

๐Ÿ“ ์š”์•ฝ

๋ณด์ด์Šค๋ฃธ ๊ธฐ๋Šฅ ์ฑ…์ž„ ๋ถ„๋ฆฌ๋ฅผ ์œ„ํ•ด ParticipantService class๋ฅผ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค.

๐Ÿ”– ๋ณ€๊ฒฝ ์‚ฌํ•ญ

  • ์ฐธ๊ฐ€์ž ์ •๋ณด ๊ด€๋ฆฌ๋ฅผ ๋‹ด๋‹นํ•˜๋Š” ParticipantService ์ถ”๊ฐ€
  • ParticipantList๋ฅผ ๊ด€๋ฆฌํ•˜๋Š” ParticipantListDto ๊ฐ์ฒด ์ถ”๊ฐ€. ParticipantList ๊ด€๋ฆฌ ์ฑ…์ž„์„ ๊ฐ–์Œ
  • ์“ฐ๋ ˆ๋“œ๋ฅผ ์ƒ์„ฑํ•ด ๋น„๋™๊ธฐ์ ์œผ๋กœ LiveKit ์„œ๋ฒ„์—์„œ ์ •๋ณด๋ฅผ ๊ฐ€์ ธ์˜ค๋Š” ์ฑ…์ž„/๋กœ์ง์€ ParticipantService๊ฐ€ ๊ฐ–๋„๋ก ํ•จ
  • ParticipantService์™€ VoiveRoomList ์‚ฌ์ด์˜ ๊ด€๊ณ„ ์˜์กด์„ฑ์„ ์—†์• ๊ธฐ ์œ„ํ•ด, List<Long roomId> ์™€ Map<Long roomId, ParticipantListDto> ํŒŒ๋ผ๋ฏธํ„ฐ๋ฅผ ํ†ตํ•ด ์˜์กด์„ฑ์„ ๊ฐ–๊ฒŒ ํ•จ

์ถ”๊ฐ€์‚ฌํ•ญ

  • ๊ธฐ์กด develop์— push ๋˜์–ด์žˆ๋˜ VoiceRoom๊ด€๋ จ ์ฝ”๋“œ์™€ ์ถฉ๋Œ์ด ๋ฐœ์ƒํ•ด ๋ฒ„๊ทธ ์ˆ˜์ • ๋ฐ ๋‘ ํด๋ž˜์Šค๋“ค์„ ์—ฐ๊ฒฐํ•ด ๊ธฐ์กด ๋™์ž‘์„ ๋ชจ๋‘ ๊ตฌํ˜„ํ•˜์˜€์Šต๋‹ˆ๋‹ค.(VoiceRoomService)

โœ… ๋ฆฌ๋ทฐ ์š”๊ตฌ์‚ฌํ•ญ

๊ฐ์ฒด ์ง€ํ–ฅ์  ๊ด€์ ์—์„œ ๋น„ํŒ ํ”ผ๋“œ๋ฐฑ ๋ถ€ํƒ๋“œ๋ฆฝ๋‹ˆ๋‹ค.

๐Ÿ“ธ ํ™•์ธ ๋ฐฉ๋ฒ• (์„ ํƒ)



๐Ÿ“Œ PR ์ง„ํ–‰ ์‹œ ์ด๋Ÿฌํ•œ ์ ๋“ค์„ ์ฐธ๊ณ ํ•ด ์ฃผ์„ธ์š”

* P1 : ๊ผญ ๋ฐ˜์˜ํ•ด ์ฃผ์„ธ์š” (Request Changes) - ์ด์Šˆ๊ฐ€ ๋ฐœ์ƒํ•˜๊ฑฐ๋‚˜ ์ทจ์•ฝ์ ์ด ๋ฐœ๊ฒฌ๋˜๋Š” ์ผ€์ด์Šค ๋“ฑ
* P2 : ๋ฐ˜์˜์„ ์ ๊ทน์ ์œผ๋กœ ๊ณ ๋ คํ•ด ์ฃผ์‹œ๋ฉด ์ข‹์„ ๊ฒƒ ๊ฐ™์•„์š” (Comment)
* P3 : ์ด๋Ÿฐ ๋ฐฉ๋ฒ•๋„ ์žˆ์„ ๊ฒƒ ๊ฐ™์•„์š”~ ๋“ฑ์˜ ์‚ฌ์†Œํ•œ ์˜๊ฒฌ์ž…๋‹ˆ๋‹ค (Chore)

@drbug2000 drbug2000 linked an issue Nov 3, 2024 that may be closed by this pull request
4 tasks
Copy link
Collaborator

@seongjunnoh seongjunnoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋ณด์ด์Šค๋ฃธ์˜ ์ฐธ์—ฌ์ž ์ •๋ณด์— ๊ด€ํ•œ ๋กœ์ง๋“ค์„ ๊ธฐ์กด voiceRoom service ์—์„œ ๋ถ„๋ฆฌํ•ด์„œ participant service ๊ฐ€ ๋‹ด๋‹นํ•˜๋„๋ก ์ฝ”๋“œ๋ฅผ ์ˆ˜์ •ํ–ˆ๋‹ค๊ณ  ํ•˜์…จ๋Š”๋ฐ, ๋ญ”๊ฐ€ ๊ฐ ๊ฐ์ฒด๊ฐ€ ์–ด๋–ค ์ผ์„ ํ•˜๋Š”์ง€๊ฐ€ ํ•œ๋ˆˆ์— ๋“ค์–ด์˜ค์ง€ ์•Š๋Š” ๋Š๋‚Œ์„ ๋ฐ›์•˜์Šต๋‹ˆ๋‹ค.
๊ฐœ์ธ์ ์ธ ์ƒ๊ฐ์œผ๋กœ๋Š” ๊ฐ์ฒด, ๊ฐ์ฒด๊ฐ€ ๊ฐ€์ง„ ์ •๋ณด๋“ค์˜ ๋„ค์ด๋ฐ์„ ์กฐ๊ธˆ ๋” ๋ช…ํ™•ํ•˜๊ณ , ๊ฐ€๋…์„ฑ ์žˆ๋„๋ก ์ˆ˜์ •ํ•ด์ฃผ์‹œ๋ฉด ๊ด€๋ จ ์ฝ”๋“œ๋“ค์„ ๋” ์‰ฝ๊ฒŒ ์ดํ•ดํ•  ์ˆ˜ ์žˆ์„ ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค!!
ํ˜น์‹œ ParticipantListDto ๋“ฑ๊ณผ ๊ฐ™์€ ๊ฐ์ฒด๋“ค์—๊ฒŒ Dto ๋ผ๊ณ  ๋„ค์ด๋ฐ์„ ํ•˜์‹  ์ด์œ ๊ฐ€ ์žˆ์„๊นŒ์š”??

@@ -28,7 +28,7 @@ public static class Response{
@Setter
public static class ParticipantInfo{
private String name;
private Long userId;
private Long id;
private Long userSpaceId;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ํ˜น์‹œ ํ•„๋“œ ๋„ค์ด๋ฐ์„ userId ์—์„œ id ๋กœ ๋ณ€๊ฒฝํ•˜์‹  ํŠน๋ณ„ํ•œ ์ด์œ ๊ฐ€ ์žˆ์„๊นŒ์š”??
ํ”„๋กœ์ ํŠธ ์ „์ฒด ์ฝ”๋“œ๋“ค์—์„œ userId ๋กœ ํ†ต์ผ๋œ ๋Š๋‚Œ์ด ์žˆ๋Š”๋ฐ, ์ด ํ•„๋“œ์˜ ๋„ค์ด๋ฐ์„ ์ˆ˜์ •ํ•˜์‹  ์ด์œ ๊ฐ€ ๊ถ๊ธˆํ•ฉ๋‹ˆ๋‹ค!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์˜๋„์™€ ๋งž๋Š”์ง„ ๋ชจ๋ฅด๊ฒ ์ง€๋งŒ ํด๋ฆฐ์ฝ”๋“œ๋ฅผ ์‹ค์ฒœํ•˜๋ ค๋ฉด ๋ถˆํ•„์š”ํ•œ ์ค‘๋ณต์€ ํ”ผํ•˜๋Š” ๊ฒŒ ์ข‹๋‹ค๊ณ  ํ•˜๋‹ˆ ๋ณ€๊ฒฝํ•œ ๋„ค์ด๋ฐ์ด ๋” ์ ์ ˆํ•  ๊ฒƒ ๊ฐ™์•„์š”!
https://dining-developer.tistory.com/68

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

participant์˜ id๋Š” LiveKit ์—์„œ ๊ฐ ์ฐธ๊ฐ€์ž๋ฅผ ๊ตฌ๋ถ„ํ•˜๋Š” id์ž…๋‹ˆ๋‹ค. userId์™€ userSpaceId๋Š” ์ €ํฌ ์„œ๋น„์Šค์—์„œ ์‚ฌ์šฉํ•˜๋Š” Id์ž…๋‹ˆ๋‹ค.
์›๋ž˜๋Š” LiveKit์—์„œ Id๊ฐ’์„ userId ๋กœ ์‚ฌ์šฉํ–ˆ์Šต๋‹ˆ๋‹ค. ํ•˜์ง€๋งŒ ๊ฐœ๋ฐœ ๊ณผ์ •์—์„œ userId๊ฐ€ ์•„๋‹Œ userSpaceId๋กœ ๋ณ€๊ฒฝ์ด ๋˜์—ˆ๊ณ , ์ด ๊ณผ์ •์—์„œ ์ฝ”๋“œ๋ฅผ ์ˆ˜์ •ํ•˜๋Š”๋ฐ ๊ฝค ๋ฒˆ๊ฑฐ๋กœ์›€?ํ—ท๊ฐˆ๋ฆผ?์ด ๋ฐœ์ƒํ–ˆ์—ˆ์Šต๋‹ˆ๋‹ค.

๋”ฐ๋ผ์„œ LiveKit id์™€ ์„œ๋น„์Šค ๋กœ์ง์˜ userSpaceId๋ฅผ ๊ตฌ๋ถ„ํ•˜์—ฌ ์ฝ”๋“œ๋ฅผ ์ž‘์„ฑํ•ด์•ผ๊ฒ ๋‹ค๊ณ  ์ƒ๊ฐํ•ด ์œ„์™€ ๊ฐ™์ด ์ˆ˜์ •ํ•˜์˜€์Šต๋‹ˆ๋‹ค.
ํ˜„์žฌ participant ๋‚ด์˜ userSpaceId์™€ id๋Š” ๊ฐ’์€ ๊ฐ™๊ณ , ์˜๋ฏธ์ ์œผ๋กœ ๋ถ„๋ฆฌํ•ด๋†“์€ ์ƒํƒœ์ž…๋‹ˆ๋‹ค.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์•„ํ•˜ ParticipantInfo ์ž์ฒด์˜ ๊ณ ์œ ํ•œ id ๋ผ๋Š” ๋ง์”€์ด์‹œ๊ตฐ์š”! ์ดํ•ดํ–ˆ์Šต๋‹ˆ๋‹ค

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์˜๋„์™€ ๋งž๋Š”์ง„ ๋ชจ๋ฅด๊ฒ ์ง€๋งŒ ํด๋ฆฐ์ฝ”๋“œ๋ฅผ ์‹ค์ฒœํ•˜๋ ค๋ฉด ๋ถˆํ•„์š”ํ•œ ์ค‘๋ณต์€ ํ”ผํ•˜๋Š” ๊ฒŒ ์ข‹๋‹ค๊ณ  ํ•˜๋‹ˆ ๋ณ€๊ฒฝํ•œ ๋„ค์ด๋ฐ์ด ๋” ์ ์ ˆํ•  ๊ฒƒ ๊ฐ™์•„์š”! https://dining-developer.tistory.com/68

์ €๋„ ์ œ๊ฐ€ ์˜ˆ์ „์— ์ž‘์„ฑํ•œ ์ฝ”๋“œ๋ณด๋ฉด์„œ ๋Š๋‚€๊ฑด๋ฐ, ๊ตณ์ด Entity ๋‚ด๋ถ€์˜ id ํ•„๋“œ๋ช…์ด userId, spaceId ์™€ ๊ฐ™์ด ์—”ํ‹ฐํ‹ฐ์˜ ์ด๋ฆ„์ด ํ•œ๋ฒˆ ๋” ์ค‘๋ณตํ•ด์„œ ๋“ค์–ด๊ฐ€ ์žˆ๋Š”๊ฒŒ ๋ถˆํ•„์š”ํ•ด ๋ณด์ด๋”๋ผ๊ณ ์š”. ๋ ˆํผ๋Ÿฐ์Šค ์ฐธ๊ณ ํ•ด์„œ ์ด ๋ถ€๋ถ„๋„ ์ˆ˜์ •ํ•ด๋ณด๊ฒ ์Šต๋‹ˆ๋‹ค!

return getParticipantDtoListById(voiceRoomId).convertParticipantDtoList();
}
private ParticipantListDto getParticipantDtoListById(long voiceRoomId){
Space space = voiceRoomRepository.findById(voiceRoomId).getSpace();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

voiceRoomRepository.findById() ๋ฉ”์„œ๋“œ๊ฐ€ Optional ๊ฐ์ฒด๋ฅผ return ํ•˜๊ณ , ์ด ๊ฒฐ๊ณผ๊ฐ’์ด null ์ธ์ง€ ๊ฒ€์ฆํ•˜๋Š” ๋กœ์ง์ด ์ถ”๊ฐ€๋˜๋ฉด ์ข‹์„๊ฑฐ ๊ฐ™์Šต๋‹ˆ๋‹ค!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space space = voiceRoomRepository.findById(voiceRoomId).orElseThrow(IllegalArgumentException::new);

์ด๋Ÿฐ ์‹์œผ๋กœ ํ•œ ์ค„์— null ์ฒ˜๋ฆฌ๋„ ๊ฐ€๋Šฅํ•ฉ๋‹ˆ๋‹น

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ํ•ด๋‹น ๋‚ด์šฉ ์ˆ˜์ •ํ•ด์„œ push ํ–ˆ์Šต๋‹ˆ๋‹ค.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์•— ์ถ”๊ฐ€๋กœ ((์ด๋ฏธ ์•Œ๊ณ  ๊ณ„์‹ค ์ˆ˜๋„ ์žˆ๊ฒ ์ง€๋งŒ))
jpa์—์„œ find ๋ฐ˜ํ™˜๊ฐ’์ด ๋ฆฌ์ŠคํŠธ์ธ ๊ฒฝ์šฐ ์กฐํšŒ ๊ฒฐ๊ณผ๊ฐ€ ์—†๋‹ค๋ฉด null์ด ์•„๋‹Œ ๋นˆ ๋ฆฌ์ŠคํŠธ๋ฅผ ๋ฐ˜ํ™˜ํ•ด์„œ
์ด ๊ฒฝ์šฐ์—” Optional ๋Œ€์‹  ๋ฆฌ์ŠคํŠธ๊ฐ€ empty์ธ์ง€๋กœ ์ฒดํฌํ•˜๋ฉด ๋œ๋‹ค๊ณ  ํ•ฉ๋‹ˆ๋‹ค!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ €๋ฒˆ์— Optional๋กœ ํ†ต์ผํ•˜๊ธฐ๋กœ ์ •ํ–ˆ์–ด์„œ Optional ์‚ฌ์šฉํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ทธ๋Ÿผ null์ธ ๊ฒฝ์šฐ ์ž์ฒด๊ฐ€ ์—†์–ด๋„ Optional๋กœ ํ†ต์ผํ•˜๋Š” ๊ฑด๊ฐ€์š”?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์˜ค๋ฅ˜๋‚˜ ์˜ˆ์™ธ์ ์ธ ์ƒํ™ฉ (์˜ˆ๋ฅผ ๋“ค์–ด ๊ธ€์„ ์ฝ๋Š” ๋„์ค‘ ๊ธ€์ด ์‚ญ์ œ๋จ. Post Entity ๊ฒ€์ƒ‰ ๋ถˆ๊ฐ€) ๋ฐœ์ƒํ•˜๋ฉด, null-pointer error๊ฐ€ ๋ฐœ์ƒํ•  ์ˆ˜ ์žˆ๋‹ค๊ณ  ์ƒ๊ฐํ•ฉ๋‹ˆ๋‹ค

Copy link
Member

@hyunn522 hyunn522 Nov 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์•— ์ถ”๊ฐ€๋กœ ((์ด๋ฏธ ์•Œ๊ณ  ๊ณ„์‹ค ์ˆ˜๋„ ์žˆ๊ฒ ์ง€๋งŒ)) jpa์—์„œ find ๋ฐ˜ํ™˜๊ฐ’์ด ๋ฆฌ์ŠคํŠธ์ธ ๊ฒฝ์šฐ ์กฐํšŒ ๊ฒฐ๊ณผ๊ฐ€ ์—†๋‹ค๋ฉด null์ด ์•„๋‹Œ ๋นˆ ๋ฆฌ์ŠคํŠธ๋ฅผ ๋ฐ˜ํ™˜ํ•ด์„œ ์ด ๊ฒฝ์šฐ์—” Optional ๋Œ€์‹  ๋ฆฌ์ŠคํŠธ๊ฐ€ empty์ธ์ง€๋กœ ์ฒดํฌํ•˜๋ฉด ๋œ๋‹ค๊ณ  ํ•ฉ๋‹ˆ๋‹ค!

์•„ ์ œ๊ฐ€ ๋ง์”€๋“œ๋ฆฐ ๊ฑด ์ด ์ผ€์ด์Šค์˜€์Šต๋‹ˆ๋‹ค! ๋‹จ์ผ ์—”ํ‹ฐํ‹ฐ๋ฅผ ๋ฐ˜ํ™˜ํ•˜๋Š” ์ผ€์ด์Šค๋Š” Optional๋กœ ํ†ต์ผํ•˜๋Š” ๊ฒƒ์ด ์ข‹์€๋ฐ
์—ฌ๋Ÿฌ ์—”ํ‹ฐํ‹ฐ๋ฅผ ๋ฆฌ์ŠคํŠธ ํ˜•ํƒœ๋กœ ๋ฐ˜ํ™˜ํ•˜๋Š” ์ผ€์ด์Šค์—์„  ๋ฐ˜ํ™˜๊ฐ’์ด null์ธ ๊ฒฝ์šฐ๊ฐ€ ์•„์˜ˆ ๋ฐœ์ƒํ•˜์ง€ ์•Š์•„์„œ์š”

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์•— ์ถ”๊ฐ€๋กœ ((์ด๋ฏธ ์•Œ๊ณ  ๊ณ„์‹ค ์ˆ˜๋„ ์žˆ๊ฒ ์ง€๋งŒ)) jpa์—์„œ find ๋ฐ˜ํ™˜๊ฐ’์ด ๋ฆฌ์ŠคํŠธ์ธ ๊ฒฝ์šฐ ์กฐํšŒ ๊ฒฐ๊ณผ๊ฐ€ ์—†๋‹ค๋ฉด null์ด ์•„๋‹Œ ๋นˆ ๋ฆฌ์ŠคํŠธ๋ฅผ ๋ฐ˜ํ™˜ํ•ด์„œ ์ด ๊ฒฝ์šฐ์—” Optional ๋Œ€์‹  ๋ฆฌ์ŠคํŠธ๊ฐ€ empty์ธ์ง€๋กœ ์ฒดํฌํ•˜๋ฉด ๋œ๋‹ค๊ณ  ํ•ฉ๋‹ˆ๋‹ค!

์•„ ์ œ๊ฐ€ ๋ง์”€๋“œ๋ฆฐ ๊ฑด ์ด ์ผ€์ด์Šค์˜€์Šต๋‹ˆ๋‹ค! ๋‹จ์ผ ์—”ํ‹ฐํ‹ฐ๋ฅผ ๋ฐ˜ํ™˜ํ•˜๋Š” ์ผ€์ด์Šค๋Š” Optional๋กœ ํ†ต์ผํ•˜๋Š” ๊ฒƒ์ด ์ข‹์€๋ฐ ์—ฌ๋Ÿฌ ์—”ํ‹ฐํ‹ฐ๋ฅผ ๋ฆฌ์ŠคํŠธ ํ˜•ํƒœ๋กœ ๋ฐ˜ํ™˜ํ•˜๋Š” ์ผ€์ด์Šค์—์„  ๋ฐ˜ํ™˜๊ฐ’์ด null์ธ ๊ฒฝ์šฐ๊ฐ€ ์•„์˜ˆ ๋ฐœ์ƒํ•˜์ง€ ์•Š์•„์„œ์š”

์˜ค ์ด๋ถ€๋ถ„์€ ๊ณตํ†ต์ ์œผ๋กœ ์ƒ๊ฐํ•ด๋ด์•ผํ• ๊ฑฐ๊ฐ™์€๋ฐ์š”? ๋ ˆํฌ์ง€ํ† ๋ฆฌ์˜ ๋ฐ˜ํ™˜๊ฐ’์ด list ์ธ ๋ฉ”์„œ๋“œ๋ฅผ ์„œ๋น„์Šค๋‹จ์ด ์‚ฌ์šฉํ•  ๋•Œ๋Š”, ํ•ด๋‹น ์ด์Šˆ ์ƒ๊ฐํ•ด์„œ ๊ฒ€์ฆํ•˜๋ฉด ์ข‹์„ ๋“ฏ ํ•ฉ๋‹ˆ๋‹ค

@drbug2000
Copy link
Collaborator Author

๋ณด์ด์Šค๋ฃธ์˜ ์ฐธ์—ฌ์ž ์ •๋ณด์— ๊ด€ํ•œ ๋กœ์ง๋“ค์„ ๊ธฐ์กด voiceRoom service ์—์„œ ๋ถ„๋ฆฌํ•ด์„œ participant service ๊ฐ€ ๋‹ด๋‹นํ•˜๋„๋ก ์ฝ”๋“œ๋ฅผ ์ˆ˜์ •ํ–ˆ๋‹ค๊ณ  ํ•˜์…จ๋Š”๋ฐ, ๋ญ”๊ฐ€ ๊ฐ ๊ฐ์ฒด๊ฐ€ ์–ด๋–ค ์ผ์„ ํ•˜๋Š”์ง€๊ฐ€ ํ•œ๋ˆˆ์— ๋“ค์–ด์˜ค์ง€ ์•Š๋Š” ๋Š๋‚Œ์„ ๋ฐ›์•˜์Šต๋‹ˆ๋‹ค. ๊ฐœ์ธ์ ์ธ ์ƒ๊ฐ์œผ๋กœ๋Š” ๊ฐ์ฒด, ๊ฐ์ฒด๊ฐ€ ๊ฐ€์ง„ ์ •๋ณด๋“ค์˜ ๋„ค์ด๋ฐ์„ ์กฐ๊ธˆ ๋” ๋ช…ํ™•ํ•˜๊ณ , ๊ฐ€๋…์„ฑ ์žˆ๋„๋ก ์ˆ˜์ •ํ•ด์ฃผ์‹œ๋ฉด ๊ด€๋ จ ์ฝ”๋“œ๋“ค์„ ๋” ์‰ฝ๊ฒŒ ์ดํ•ดํ•  ์ˆ˜ ์žˆ์„ ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค!! ํ˜น์‹œ ParticipantListDto ๋“ฑ๊ณผ ๊ฐ™์€ ๊ฐ์ฒด๋“ค์—๊ฒŒ Dto ๋ผ๊ณ  ๋„ค์ด๋ฐ์„ ํ•˜์‹  ์ด์œ ๊ฐ€ ์žˆ์„๊นŒ์š”??

์›๋ž˜ Dto๋กœ ๋ถ€ํ„ฐ ์œ ๋ž˜ํ•œ ๊ฐ์ฒด๋ผ ๊ด€์„ฑ์ ์œผ๋กœ ์‚ฌ์šฉ์ค‘์ด์—ˆ์Šต๋‹ˆ๋‹ค.
๋‹ค๋ฅธ ์šฉ์–ด๋ฅผ ๋ถ™์ด์ž๋‹ˆ ์˜๋ฏธ์ ์ด๋‚˜, ์•„ํ‚คํ…์ณ์— ๋ฒ—์–ด๋‚˜๋Š” ๊ฒƒ ๊ฐ™๊ณ , ๊ทธ๋ƒฅ ParticipantList๋ฅผ ์“ฐ์ž๋‹ˆ List์™€ ํ—ท๊ฐˆ๋ฆด ์ˆ˜ ์žˆ๋‹ค๊ณ  ์ƒ๊ฐํ–ˆ์Šต๋‹ˆ๋‹ค.
ํ˜น์‹œ ์ข‹์€ ์ด๋ฆ„ ์žˆ์œผ๋ฉด ์ถ”์ฒœ ํ•ด์ฃผ์„ธ์š”...

๊ทธ๋ฆฌ๊ณ  ํ˜„์žฌ VoiceRoom์˜ ๊ฐ ๊ฐ์ฒด๋“ค์€ ์–ด๋–ค ์—ญํ• ?ํ–‰๋™์„ ๋งก๊ณ  ์žˆ์ง€๋Š” ์•Š์Šต๋‹ˆ๋‹ค.
๊ฑฐ์˜ ๋Œ€๋ถ€๋ถ„ ๋ฐ์ดํ„ฐ๋ฅผ ๊ฐ์‹ธ๊ณ , ๊ทธ ๋ฐ์ดํ„ฐ๋ฅผ ์™ธ๋ถ€์™€ ๋ถ„๋ฆฌํ•ด์„œ ๊ด€ํ•˜๊ณ , ์ฃผ๊ณ  ๋ฐ›๋Š” ์šฉ๋„๋กœ ๋งŒ๋“ค์–ด์ง„ ๊ฐ์ฒด๋“ค์ž…๋‹ˆ๋‹ค.

@hyunn522
Copy link
Member

hyunn522 commented Nov 5, 2024

๋ณด์ด์Šค๋ฃธ์˜ ์ฐธ์—ฌ์ž ์ •๋ณด์— ๊ด€ํ•œ ๋กœ์ง๋“ค์„ ๊ธฐ์กด voiceRoom service ์—์„œ ๋ถ„๋ฆฌํ•ด์„œ participant service ๊ฐ€ ๋‹ด๋‹นํ•˜๋„๋ก ์ฝ”๋“œ๋ฅผ ์ˆ˜์ •ํ–ˆ๋‹ค๊ณ  ํ•˜์…จ๋Š”๋ฐ, ๋ญ”๊ฐ€ ๊ฐ ๊ฐ์ฒด๊ฐ€ ์–ด๋–ค ์ผ์„ ํ•˜๋Š”์ง€๊ฐ€ ํ•œ๋ˆˆ์— ๋“ค์–ด์˜ค์ง€ ์•Š๋Š” ๋Š๋‚Œ์„ ๋ฐ›์•˜์Šต๋‹ˆ๋‹ค. ๊ฐœ์ธ์ ์ธ ์ƒ๊ฐ์œผ๋กœ๋Š” ๊ฐ์ฒด, ๊ฐ์ฒด๊ฐ€ ๊ฐ€์ง„ ์ •๋ณด๋“ค์˜ ๋„ค์ด๋ฐ์„ ์กฐ๊ธˆ ๋” ๋ช…ํ™•ํ•˜๊ณ , ๊ฐ€๋…์„ฑ ์žˆ๋„๋ก ์ˆ˜์ •ํ•ด์ฃผ์‹œ๋ฉด ๊ด€๋ จ ์ฝ”๋“œ๋“ค์„ ๋” ์‰ฝ๊ฒŒ ์ดํ•ดํ•  ์ˆ˜ ์žˆ์„ ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค!! ํ˜น์‹œ ParticipantListDto ๋“ฑ๊ณผ ๊ฐ™์€ ๊ฐ์ฒด๋“ค์—๊ฒŒ Dto ๋ผ๊ณ  ๋„ค์ด๋ฐ์„ ํ•˜์‹  ์ด์œ ๊ฐ€ ์žˆ์„๊นŒ์š”??

์›๋ž˜ Dto๋กœ ๋ถ€ํ„ฐ ์œ ๋ž˜ํ•œ ๊ฐ์ฒด๋ผ ๊ด€์„ฑ์ ์œผ๋กœ ์‚ฌ์šฉ์ค‘์ด์—ˆ์Šต๋‹ˆ๋‹ค. ๋‹ค๋ฅธ ์šฉ์–ด๋ฅผ ๋ถ™์ด์ž๋‹ˆ ์˜๋ฏธ์ ์ด๋‚˜, ์•„ํ‚คํ…์ณ์— ๋ฒ—์–ด๋‚˜๋Š” ๊ฒƒ ๊ฐ™๊ณ , ๊ทธ๋ƒฅ ParticipantList๋ฅผ ์“ฐ์ž๋‹ˆ List์™€ ํ—ท๊ฐˆ๋ฆด ์ˆ˜ ์žˆ๋‹ค๊ณ  ์ƒ๊ฐํ–ˆ์Šต๋‹ˆ๋‹ค. ํ˜น์‹œ ์ข‹์€ ์ด๋ฆ„ ์žˆ์œผ๋ฉด ์ถ”์ฒœ ํ•ด์ฃผ์„ธ์š”...

๊ทธ๋ฆฌ๊ณ  ํ˜„์žฌ VoiceRoom์˜ ๊ฐ ๊ฐ์ฒด๋“ค์€ ์–ด๋–ค ์—ญํ• ?ํ–‰๋™์„ ๋งก๊ณ  ์žˆ์ง€๋Š” ์•Š์Šต๋‹ˆ๋‹ค. ๊ฑฐ์˜ ๋Œ€๋ถ€๋ถ„ ๋ฐ์ดํ„ฐ๋ฅผ ๊ฐ์‹ธ๊ณ , ๊ทธ ๋ฐ์ดํ„ฐ๋ฅผ ์™ธ๋ถ€์™€ ๋ถ„๋ฆฌํ•ด์„œ ๊ด€ํ•˜๊ณ , ์ฃผ๊ณ  ๋ฐ›๋Š” ์šฉ๋„๋กœ ๋งŒ๋“ค์–ด์ง„ ๊ฐ์ฒด๋“ค์ž…๋‹ˆ๋‹ค.

์ฝ”๋“œ๋ฅผ ๋ณด๋‹ˆ service ๊ณ„์ธต ๋‚ด์—์„œ๋งŒ ์‚ฌ์šฉ๋˜๊ณ  ํ•ด๋‹น ํด๋ž˜์Šค ๋‚ด์—์„œ ํ•„๋“œ๊ฐ€ ๋ณ€ํ•˜์ง€ ์•Š๋Š” ๊ฒƒ ๊ฐ™์€๋ฐ,
๊ทธ๋ ‡๋‹ค๋ฉด VO๋ฅผ ๋„์ž…ํ•ด๋ณด์‹œ๋Š” ๊ฒƒ๋„ ์ข‹์„ ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค
https://maenco.tistory.com/entry/Java-DTO%EC%99%80-VO%EC%9D%98-%EC%B0%A8%EC%9D%B4

public class ParticipantListDto {


private List<ParticipantDto> participantDtoList;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

final์„ ์ ์šฉํ•˜์‹œ์ง€ ์•Š์€ ์ด์œ ๊ฐ€ ์žˆ์„๊นŒ์š”?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋ถˆ๋ณ€์„ฑ์ด ์—†์–ด์„œ final์„ ๋ถ™์ด์ง€ ์•Š์•˜์Šต๋‹ˆ๋‹ค.
ํ•˜์ง€๋งŒ, ์žฌํ• ๋‹น์„ ๋ง‰๊ธฐ ์œ„ํ•ด์„œ final์„ ์ถ”๊ฐ€ํ•˜๋Š” ๊ฒƒ์ด ์•ˆ์ •์„ฑ ๋ฉด์—์„œ ์ข‹์•„๋ณด์ด๋„ค์š”!
ํ•„์š”ํ•œ ํด๋ž˜์Šค์— ์ถ”๊ฐ€ํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋„ต ๋งŒ์•ฝ ๋ถˆ๋ณ€์„ฑ๊นŒ์ง€ ๋ณด์žฅํ•˜๋ ค๋ฉด ์ƒ์„ฑํ•  ๋•Œ unmodifiable๋กœ ๋„ฃ์–ด์ฃผ๋ฉด ๋  ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค

@drbug2000
Copy link
Collaborator Author

๋ณด์ด์Šค๋ฃธ์˜ ์ฐธ์—ฌ์ž ์ •๋ณด์— ๊ด€ํ•œ ๋กœ์ง๋“ค์„ ๊ธฐ์กด voiceRoom service ์—์„œ ๋ถ„๋ฆฌํ•ด์„œ participant service ๊ฐ€ ๋‹ด๋‹นํ•˜๋„๋ก ์ฝ”๋“œ๋ฅผ ์ˆ˜์ •ํ–ˆ๋‹ค๊ณ  ํ•˜์…จ๋Š”๋ฐ, ๋ญ”๊ฐ€ ๊ฐ ๊ฐ์ฒด๊ฐ€ ์–ด๋–ค ์ผ์„ ํ•˜๋Š”์ง€๊ฐ€ ํ•œ๋ˆˆ์— ๋“ค์–ด์˜ค์ง€ ์•Š๋Š” ๋Š๋‚Œ์„ ๋ฐ›์•˜์Šต๋‹ˆ๋‹ค. ๊ฐœ์ธ์ ์ธ ์ƒ๊ฐ์œผ๋กœ๋Š” ๊ฐ์ฒด, ๊ฐ์ฒด๊ฐ€ ๊ฐ€์ง„ ์ •๋ณด๋“ค์˜ ๋„ค์ด๋ฐ์„ ์กฐ๊ธˆ ๋” ๋ช…ํ™•ํ•˜๊ณ , ๊ฐ€๋…์„ฑ ์žˆ๋„๋ก ์ˆ˜์ •ํ•ด์ฃผ์‹œ๋ฉด ๊ด€๋ จ ์ฝ”๋“œ๋“ค์„ ๋” ์‰ฝ๊ฒŒ ์ดํ•ดํ•  ์ˆ˜ ์žˆ์„ ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค!! ํ˜น์‹œ ParticipantListDto ๋“ฑ๊ณผ ๊ฐ™์€ ๊ฐ์ฒด๋“ค์—๊ฒŒ Dto ๋ผ๊ณ  ๋„ค์ด๋ฐ์„ ํ•˜์‹  ์ด์œ ๊ฐ€ ์žˆ์„๊นŒ์š”??

์›๋ž˜ Dto๋กœ ๋ถ€ํ„ฐ ์œ ๋ž˜ํ•œ ๊ฐ์ฒด๋ผ ๊ด€์„ฑ์ ์œผ๋กœ ์‚ฌ์šฉ์ค‘์ด์—ˆ์Šต๋‹ˆ๋‹ค. ๋‹ค๋ฅธ ์šฉ์–ด๋ฅผ ๋ถ™์ด์ž๋‹ˆ ์˜๋ฏธ์ ์ด๋‚˜, ์•„ํ‚คํ…์ณ์— ๋ฒ—์–ด๋‚˜๋Š” ๊ฒƒ ๊ฐ™๊ณ , ๊ทธ๋ƒฅ ParticipantList๋ฅผ ์“ฐ์ž๋‹ˆ List์™€ ํ—ท๊ฐˆ๋ฆด ์ˆ˜ ์žˆ๋‹ค๊ณ  ์ƒ๊ฐํ–ˆ์Šต๋‹ˆ๋‹ค. ํ˜น์‹œ ์ข‹์€ ์ด๋ฆ„ ์žˆ์œผ๋ฉด ์ถ”์ฒœ ํ•ด์ฃผ์„ธ์š”...
๊ทธ๋ฆฌ๊ณ  ํ˜„์žฌ VoiceRoom์˜ ๊ฐ ๊ฐ์ฒด๋“ค์€ ์–ด๋–ค ์—ญํ• ?ํ–‰๋™์„ ๋งก๊ณ  ์žˆ์ง€๋Š” ์•Š์Šต๋‹ˆ๋‹ค. ๊ฑฐ์˜ ๋Œ€๋ถ€๋ถ„ ๋ฐ์ดํ„ฐ๋ฅผ ๊ฐ์‹ธ๊ณ , ๊ทธ ๋ฐ์ดํ„ฐ๋ฅผ ์™ธ๋ถ€์™€ ๋ถ„๋ฆฌํ•ด์„œ ๊ด€ํ•˜๊ณ , ์ฃผ๊ณ  ๋ฐ›๋Š” ์šฉ๋„๋กœ ๋งŒ๋“ค์–ด์ง„ ๊ฐ์ฒด๋“ค์ž…๋‹ˆ๋‹ค.

์ฝ”๋“œ๋ฅผ ๋ณด๋‹ˆ service ๊ณ„์ธต ๋‚ด์—์„œ๋งŒ ์‚ฌ์šฉ๋˜๊ณ  ํ•ด๋‹น ํด๋ž˜์Šค ๋‚ด์—์„œ ํ•„๋“œ๊ฐ€ ๋ณ€ํ•˜์ง€ ์•Š๋Š” ๊ฒƒ ๊ฐ™์€๋ฐ, ๊ทธ๋ ‡๋‹ค๋ฉด VO๋ฅผ ๋„์ž…ํ•ด๋ณด์‹œ๋Š” ๊ฒƒ๋„ ์ข‹์„ ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค https://maenco.tistory.com/entry/Java-DTO%EC%99%80-VO%EC%9D%98-%EC%B0%A8%EC%9D%B4

service ๊ณ„์ธต ๋‚ด์—์„œ๋งŒ ์‚ฌ์šฉ๋˜๋Š” ๊ฒƒ์€ ๋งž์ง€๋งŒ, ์‚ฌ์šฉ๋˜๋ฉด์„œ ๋‚ด๋ถ€ ๋ฉค๋ฒ„๋“ค์˜ ๊ฐ’์€ ๊ณ„์† ์ˆ˜์ •๋˜๊ธด ํ•ฉ๋‹ˆ๋‹ค.
๊ทธ๋ž˜๋„ setter getter๊ฐ€ ์—†๋Š” ์ , ๊ฐ’์„ ๊ฐ–๋Š” ์ ์ด DTO๋ณด๋‹ค๋Š” VO์— ๊ฐ€๊นŒ์šธ ์ˆ˜ ์žˆ๊ฒ ๋„ค์š”!

@seongjunnoh
Copy link
Collaborator

๋ณด์ด์Šค๋ฃธ์˜ ์ฐธ์—ฌ์ž ์ •๋ณด์— ๊ด€ํ•œ ๋กœ์ง๋“ค์„ ๊ธฐ์กด voiceRoom service ์—์„œ ๋ถ„๋ฆฌํ•ด์„œ participant service ๊ฐ€ ๋‹ด๋‹นํ•˜๋„๋ก ์ฝ”๋“œ๋ฅผ ์ˆ˜์ •ํ–ˆ๋‹ค๊ณ  ํ•˜์…จ๋Š”๋ฐ, ๋ญ”๊ฐ€ ๊ฐ ๊ฐ์ฒด๊ฐ€ ์–ด๋–ค ์ผ์„ ํ•˜๋Š”์ง€๊ฐ€ ํ•œ๋ˆˆ์— ๋“ค์–ด์˜ค์ง€ ์•Š๋Š” ๋Š๋‚Œ์„ ๋ฐ›์•˜์Šต๋‹ˆ๋‹ค. ๊ฐœ์ธ์ ์ธ ์ƒ๊ฐ์œผ๋กœ๋Š” ๊ฐ์ฒด, ๊ฐ์ฒด๊ฐ€ ๊ฐ€์ง„ ์ •๋ณด๋“ค์˜ ๋„ค์ด๋ฐ์„ ์กฐ๊ธˆ ๋” ๋ช…ํ™•ํ•˜๊ณ , ๊ฐ€๋…์„ฑ ์žˆ๋„๋ก ์ˆ˜์ •ํ•ด์ฃผ์‹œ๋ฉด ๊ด€๋ จ ์ฝ”๋“œ๋“ค์„ ๋” ์‰ฝ๊ฒŒ ์ดํ•ดํ•  ์ˆ˜ ์žˆ์„ ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค!! ํ˜น์‹œ ParticipantListDto ๋“ฑ๊ณผ ๊ฐ™์€ ๊ฐ์ฒด๋“ค์—๊ฒŒ Dto ๋ผ๊ณ  ๋„ค์ด๋ฐ์„ ํ•˜์‹  ์ด์œ ๊ฐ€ ์žˆ์„๊นŒ์š”??

์›๋ž˜ Dto๋กœ ๋ถ€ํ„ฐ ์œ ๋ž˜ํ•œ ๊ฐ์ฒด๋ผ ๊ด€์„ฑ์ ์œผ๋กœ ์‚ฌ์šฉ์ค‘์ด์—ˆ์Šต๋‹ˆ๋‹ค. ๋‹ค๋ฅธ ์šฉ์–ด๋ฅผ ๋ถ™์ด์ž๋‹ˆ ์˜๋ฏธ์ ์ด๋‚˜, ์•„ํ‚คํ…์ณ์— ๋ฒ—์–ด๋‚˜๋Š” ๊ฒƒ ๊ฐ™๊ณ , ๊ทธ๋ƒฅ ParticipantList๋ฅผ ์“ฐ์ž๋‹ˆ List์™€ ํ—ท๊ฐˆ๋ฆด ์ˆ˜ ์žˆ๋‹ค๊ณ  ์ƒ๊ฐํ–ˆ์Šต๋‹ˆ๋‹ค. ํ˜น์‹œ ์ข‹์€ ์ด๋ฆ„ ์žˆ์œผ๋ฉด ์ถ”์ฒœ ํ•ด์ฃผ์„ธ์š”...

๊ทธ๋ฆฌ๊ณ  ํ˜„์žฌ VoiceRoom์˜ ๊ฐ ๊ฐ์ฒด๋“ค์€ ์–ด๋–ค ์—ญํ• ?ํ–‰๋™์„ ๋งก๊ณ  ์žˆ์ง€๋Š” ์•Š์Šต๋‹ˆ๋‹ค. ๊ฑฐ์˜ ๋Œ€๋ถ€๋ถ„ ๋ฐ์ดํ„ฐ๋ฅผ ๊ฐ์‹ธ๊ณ , ๊ทธ ๋ฐ์ดํ„ฐ๋ฅผ ์™ธ๋ถ€์™€ ๋ถ„๋ฆฌํ•ด์„œ ๊ด€ํ•˜๊ณ , ์ฃผ๊ณ  ๋ฐ›๋Š” ์šฉ๋„๋กœ ๋งŒ๋“ค์–ด์ง„ ๊ฐ์ฒด๋“ค์ž…๋‹ˆ๋‹ค.

์Œ Room, VoiceRoom, Participant ์˜ ๋„ค์ด๋ฐ์„ ๋ณด์•˜์„ ๋•Œ ํ•ด๋‹น DTO ๋“ค์ด ์–ด๋–ค ๋™์ž‘๊ณผ ๊ด€๋ จ๋œ data ๋“ค์„ ๊ด€๋ฆฌํ•˜๋Š”์ง€๊ฐ€ ๋ช…ํ™•ํ•˜๊ฒŒ ์ดํ•ด๋˜์ง€ ์•Š๋Š”๋‹ค? ๋ผ๋Š” ๊ฐœ์ธ์ ์ธ ์˜๊ฒฌ์ด์—ˆ์Šต๋‹ˆ๋‹ค!

์„œ๋น„์Šค๋‹จ์˜ ์ฝ”๋“œ๋ฅผ ๋ณด๊ณ  ์–ด๋–ค ํ”Œ๋กœ์šฐ๋กœ ๋ณด์ด์Šค๋ฃธ ์ฐธ์—ฌ์ž ๊ด€๋ฆฌ๊ฐ€ ๋™์ž‘ํ•˜๋Š”๊ตฌ๋‚˜ ๋ผ๋Š” ๊ฒƒ์ด ๋ช…ํ™•ํžˆ ๋ˆˆ์— ๋“ค์–ด์˜ค๋Š” ๊ฒƒ์ด ๋ฆฌํŽ™ํ† ๋ง ์‹œ์— ๊ฐ€์žฅ ์šฐ์„ ์ˆœ์œ„๊ฐ€ ๋†’์ง€ ์•Š์„๊นŒ ๋ผ๊ณ  ์ƒ๊ฐํ•ฉ๋‹ˆ๋‹ค.
(์‚ฌ์‹ค ๋ณด์ด์Šค๋ฃธ ๊ด€๋ จ ๋กœ์ง์˜ ํ”Œ๋กœ์šฐ์— ๋Œ€ํ•œ ๋ฐฐ๊ฒฝ์ง€์‹์ด ์—†์–ด์„œ ๊ทธ๋Ÿฐ๊ฑฐ ๊ฐ™๊ธฐ๋„ ํ•˜๋„ค์š”)

๊ทธ๋ฆฌ๊ณ  ์„œ๋น„์Šค๋‹จ์—์„œ dto ๊ฐ์ฒด๋“ค๋กœ๋ถ€ํ„ฐ data ๋งŒ์„ ์ฃผ๊ณ ๋ฐ›๋Š”๋‹ค๊ณ  ํ•˜์…จ๋Š”๋ฐ, ํ˜น์‹œ ์„œ๋น„์Šค๋‹จ์˜ ๋กœ์ง์˜ ์ผ๋ถ€๋ฅผ ๋‹ด๋‹นํ•˜๋Š” ๊ฐ์ฒด๋ฅผ ๋งŒ๋“œ์‹ค ์ƒ๊ฐ์€ ์—†์œผ์‹ ๊ฐ€์š”??
๋ณด์ด์Šค๋ฃธ ์ฐธ์—ฌ์ž ๊ด€๋ฆฌ ๋กœ์ง ํ”Œ๋กœ์šฐ์˜ ํŠน์ • ๋ถ€๋ถ„์— ๋Œ€ํ•œ ์ฑ…์ž„์„ ๋งก๋Š” ๊ฐ์ฒด๊ฐ€ ์žˆ๋‹ค๋ฉด, ์ด ๋กœ์ง์— ๋Œ€ํ•œ ํ…Œ์ŠคํŒ…๋„ ํŽธ๋ฆฌํ•ด์ง€๊ณ  ์ฝ”๋“œ์˜ ๊ฐ€๋…์„ฑ๋„ ๋” ์ข‹์•„์ง€์ง€ ์•Š์„๊นŒ ์‹ถ์Šต๋‹ˆ๋‹ค!

import space.space_spring.domain.user.repository.UserDao;
import space.space_spring.domain.userSpace.repository.UserSpaceDao;
import space.space_spring.dto.VoiceRoom.GetParticipantList;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drbug2000 drbug2000 merged commit 78f2f30 into develop Jan 9, 2025
3 checks passed
@hyunn522 hyunn522 deleted the feat/#163/Participant-service branch January 9, 2025 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat : Participant service
3 participants