Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
2 tasks
seongjunnoh
approved these changes
Aug 15, 2024
| case "text/plain" -> fileExtension = "txt"; | ||
| default -> log.error("Unsupported file prefix: " + filePrefix); | ||
| } | ||
|
|
There was a problem hiding this comment.
나중에 리펙토링시 enum 으로 관리하면 더 좋을것 같습니다!
| log.info("Unsupported file prefix: " + filePrefix); | ||
| yield ".bin"; // 기본 확장자 | ||
| } | ||
| }; |
There was a problem hiding this comment.
오 이렇게 메소드로 책임 분리하는거 좋습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 요약
🔖 변경 사항
✅ 리뷰 요구사항
약 2MB까지 테스트해보았을 때 잘 작동했습니다 S3에 업로드된 거 확인해주시면 될 것 같아요
📸 확인 방법 (선택)
📌 PR 진행 시 이러한 점들을 참고해 주세요