refactor : PayRequest 엔티티가 target으로부터 돈을 받는 행동을 가지도록 코드 수정

KUIT-Space · Nov 20, 2024 · 844c2c2 · 844c2c2
1 parent b93b6a7
commit 844c2c2
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 9 deletions.
diff --git a/src/main/java/space/space_spring/domain/pay/model/entity/PayRequest.java b/src/main/java/space/space_spring/domain/pay/model/entity/PayRequest.java
@@ -55,8 +55,8 @@ public void changeCompleteStatus(boolean isComplete) {
         this.isComplete = isComplete;
     }
 
-    public void changeReceiveAmount(int receiveAmount) {
-        this.receiveAmount = receiveAmount;
+    public void receiveMoneyFromTarget(int money) {
+        receiveAmount += money;
     }
 
     public void addPayRequestTarget(PayRequestTarget payRequestTarget) {

diff --git a/src/test/java/space/space_spring/domain/pay/model/entity/PayRequestTest.java b/src/test/java/space/space_spring/domain/pay/model/entity/PayRequestTest.java
@@ -7,8 +7,6 @@
 import space.space_spring.domain.user.model.entity.User;
 import space.space_spring.entity.enumStatus.UserSignupType;
 
-import java.util.List;
-
 import static org.assertj.core.api.Assertions.assertThat;
 
 class PayRequestTest {
@@ -30,7 +28,7 @@ void getPayRequestInfo() throws Exception {
         // target1 : 미정산, target2, target3 : 정산 완료
         target2.changeCompleteStatus(true);
         target3.changeCompleteStatus(true);
-        payRequest.changeReceiveAmount(20000);
+        payRequest.receiveMoneyFromTarget(20000);
 
         //when
         PayRequestInfoDto payRequestInfo = payRequest.getPayRequestInfo();

diff --git a/src/test/java/space/space_spring/domain/pay/model/firstCollection/PayRequestsTest.java b/src/test/java/space/space_spring/domain/pay/model/firstCollection/PayRequestsTest.java
@@ -1,6 +1,5 @@
 package space.space_spring.domain.pay.model.firstCollection;
 
-import org.assertj.core.groups.Tuple;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.DisplayName;
 import org.junit.jupiter.api.Test;
@@ -14,7 +13,6 @@
 
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.assertj.core.api.Assertions.tuple;
-import static org.junit.jupiter.api.Assertions.*;
 
 class PayRequestsTest {
 
@@ -47,10 +45,10 @@ void getPayRequestInfos() throws Exception {
         PayRequestTarget target4 = PayRequestTarget.create(payRequest2, 4L, 30000);
 
         target1.changeCompleteStatus(true);         // payRequest1 에 대해서 target1은 정산 완료
-        payRequest1.changeReceiveAmount(20000);
+        payRequest1.receiveMoneyFromTarget(20000);
 
         target3.changeCompleteStatus(true);         // payRequest2 에 대해서 target3은 정산 완료
-        payRequest2.changeReceiveAmount(10000);
+        payRequest2.receiveMoneyFromTarget(10000);
 
         PayRequests payCreatorIsSeongjun = PayRequests.create(List.of(payRequest1, payRequest2));