Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: signup user flow & verification logic #98

Merged
merged 9 commits into from
Aug 19, 2024
Merged

Fix: signup user flow & verification logic #98

merged 9 commits into from
Aug 19, 2024

Conversation

Turtle-Hwan
Copy link
Member

@Turtle-Hwan Turtle-Hwan commented Aug 19, 2024 •
edited
Loading

Summary

#35

  • 회원가입 시에도 로그인 안 되어있으면 로그인 하라고 모달창 뜨는 문제 수정 9eb9288
  • 회원가입 페이지에서 중간에 이메일, 비밀번호 등 검증 실패하면 그 즉시 alert등 사용자에게 표시해주고 다시 입력하라 하기
  • enter 키 누르면 버튼 작동하게 하기
  • 동일 이메일 가입 시도 시 백엔드에서 검증 후 날아오는 메세지 보여주고, 다시 입력 화면으로 돌아가기

#1
KUIT-Space/KUIT_Space_BackEnd#128

PR 유형 및 세부 작업 내용

@Turtle-Hwan Turtle-Hwan self-assigned this Aug 19, 2024
@Turtle-Hwan Turtle-Hwan added bug Something isn't working Feat New feature or request labels Aug 19, 2024
@Turtle-Hwan Turtle-Hwan marked this pull request as draft August 19, 2024 04:51
@Turtle-Hwan Turtle-Hwan linked an issue Aug 19, 2024 that may be closed by this pull request
[FEAT] 회원가입 #35
Closed
4 tasks
@Turtle-Hwan Turtle-Hwan removed a link to an issue Aug 19, 2024
[FEAT] 회원가입 #35
Closed
4 tasks
@Turtle-Hwan Turtle-Hwan linked an issue Aug 19, 2024 that may be closed by this pull request
[FEAT] 회원가입 #35
Closed
4 tasks
@Turtle-Hwan Turtle-Hwan marked this pull request as ready for review August 19, 2024 06:33
YangJJune
YangJJune approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@YangJJune YangJJune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Turtle-Hwan Turtle-Hwan merged commit f80a37c into main Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YangJJune YangJJune YangJJune approved these changes

Assignees

@Turtle-Hwan Turtle-Hwan

Labels
bug Something isn't working Feat New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT] 회원가입
2 participants
@Turtle-Hwan @YangJJune