Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create BottonBtn.tsx #29

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Create BottonBtn.tsx #29

merged 1 commit into from
Jul 19, 2024

Conversation

YangJJune
Copy link
Contributor

Summary

하단에 자주 사용되는 버튼을 style만 잘라서 컴포넌트에 일단 넣었습니다
#28

PR 유형 및 세부 작업 내용

  • 새로운 기능 추가

사용법

버튼과 똑같은 형태로 사용하면되며, disabled를 true 또는 false로 설정하여 스타일 변경 가능합니다.

<BottomBtn disabled={spaceName === "" ? true : false}>생성하기</BottomBtn>

<BottomBtn disabled={false}>참여하기</BottomBtn>

작동 스크린샷

image

리뷰 요구사항

조금 헷갈리는 부분이 style만 떼오는 것도 component인지, style 폴더에 들어가야하는지 모르겠네요

Copy link
Member

@Turtle-Hwan Turtle-Hwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

디자이너 분들이 버튼, navigation, bar 등 소규모 ui를 component로 이름지어 두셨고,
해당 button도 styled-component 이니까
component 폴더에 들어가는 것이 덜 헷갈릴 것 같습니다

style 폴더에는 전역 스타일링이나 theme 관련 design-token 위주로 넣으면 좋을 것 같아요

@Turtle-Hwan Turtle-Hwan linked an issue Jul 19, 2024 that may be closed by this pull request
2 tasks
Copy link
Collaborator

@woo319 woo319 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@YangJJune YangJJune merged commit 491e308 into main Jul 19, 2024
@Turtle-Hwan Turtle-Hwan linked an issue Aug 4, 2024 that may be closed by this pull request
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] 공용 style [FEAT] 자주 사용하는 BottomBtn의 개발
3 participants