Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BDB Generic Configs #2823

Open
wants to merge 7 commits into
base: BDBStagingBranch
Choose a base branch
from
Open

BDB Generic Configs #2823

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
bf5ef8e
BDB Generic Configs
SkyPhoenix999 Apr 1, 2023
bc9656a
Add files via upload
SkyPhoenix999 Dec 3, 2023
a2d385b
Delete GameData/RealismOverhaul/RO_SuggestedMods/Bluedog_DB/Generic/W…
SkyPhoenix999 Dec 3, 2023
4a98726
Improve generic configs
Capkirk123 Dec 10, 2023
fa7aa95
Tank Mass Fix
SkyPhoenix999 Apr 12, 2024
a245e91
Don't bulk-patch RF tanks pls
Capkirk123 Apr 14, 2024
d154e50
- The FAR Update
SkyPhoenix999 Jul 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions GameData/RealismOverhaul/RO_SuggestedMods/Bluedog_DB/Generic/RO_General_Stuff.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
// ================================================================================


// Real Titles
// Real Titles
@PART[bluedog*,Bluedog*]:FOR[RealismOverhaul]
{
!real_title = NULL
Expand All @@ -12,7 +12,7 @@
}


// Engine Effect Fix
// Engine Effect Fix
@PART[bluedog*,Bluedog*]:HAS[@MODULE[ModuleEnginesFX]]:BEFORE[RealismOverhaul]
{
@MODULE[ModuleEnginesFX],*
Expand All @@ -22,11 +22,21 @@
}


// MPF Part Cleanup (SAF and PF Fairings kept, MPF not used in RO)
// Tank Mass Fix
@PART[bluedog*,Bluedog*]:HAS[@MODULE[ModuleFuelTanks]]:AFTER[RealismOverhaulTankTypes]
{
@MODULE[ModuleFuelTanks],*
{
@basemass = -1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not do this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idk what else is going to work then, because the RF Config keeps adding mass to the tanks, for small parts like Able the added mass makes it almost unusable.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not experienced this issue. They may be configured wrong, or it may be BDB itself adding them mass (BDB multiplies the mass of parts as a function of the solar system rescale, a feature which should be removed with the next release but has not yet been)

Copy link
Contributor Author

@SkyPhoenix999 SkyPhoenix999 Apr 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've installed that fix you made for the mass.

From everything I've checked it's not BDB, it's the RF config, the basemass part of each TANK_DEFINITION will add mass to the tanks once propellant is set on the tank.

Deleting the tank in the editor gets rid of the added mass, but adding the tank back will add the mass back as well, this isn't because of the fuel either, the drymass is just raised.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then it's a config issue on the RF side.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well bluedog_DeltaB_Tank has two tanks in it, one of which is a service module, which would explain why it's so heavy. I suspect the rest are also config issues of a similar nature.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking the configs (The Able PR configs) there's only one Tank. I'm not sure why there would be a second service module tank in there. #2807

Will test further soon.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
And there you have it.

Base mass is being set in the RFTank module, which means RF will apply base mass as it sees fit.

RFTanks should be configured one of two ways. Either basemass should be set to -1, in which case RF will not try to alter the tank mass in any way, or basemass should be set to a sensible value for an empty structural shell, and RF allowed to add the appropriate tank mass such that the total dry mass adds up to the appropriate value. I would much prefer the latter method be used, but the former is acceptable for dumb fuel tanks and such if you don't want to spend the time setting the mass appropriately.

basemass should be set to -1 on a part-by-part basis, and not bulk patched to -1, since I prefer to configure parts using the second method.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, Able has been fixed here. Any other dry mass issues should be fixed in the same manner.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made General corrections to the Able configs here with your suggestions and additions, corrected tank masses and relocating waterfall to match with the rest of the BDB PRs

}
}


// MPF Part Cleanup (SAF and PF Fairings kept, MPF not used in RO)
!PART[bluedog*,Bluedog*]:HAS[@MODULE[ModuleProceduralFairing]]:NEEDS[ProceduralFairings]:AFTER[zzzRealismOverhaul] {}
!PART[bluedog_spacelab_forwardAdapter_PF]:NEEDS[ProceduralFairings]:AFTER[zzzRealismOverhaul] {}
!PART[bluedog_Skylab_airlockModule_PF]:NEEDS[ProceduralFairings]:AFTER[zzzRealismOverhaul] {}


// Depreciated Part Cleanup
// Depreciated Part Cleanup
!PART[bluedog*,Bluedog*]:HAS[#TechHidden[True]]:AFTER[zzzRealismOverhaul] {}
Loading