Merge & Deprecate XLR43 #2513
Merge & Deprecate XLR43 #2513
Conversation
| @@ -270,7 +350,7 @@ | |||
| ignitionReliabilityEnd = 0.97 | |||
| cycleReliabilityStart = 0.77 // a bit higher than XLR43-NA-1 | |||
| cycleReliabilityEnd = 0.94 | |||
| techTransfer = XLR41-NA-1:30&XLR43-NA-1:50 // A-4/V-2 derivative. Modified XLR43-NA-1 | |||
| techTransfer = XLR41-NA-1,XLR43-NA-1:50 // A-4/V-2 derivative. Modified XLR43-NA-1 | |||
There was a problem hiding this comment.
Why increase the transfer from the XLR41 here? (That opens up a larger question I guess, which I've just added to #2505)
| @@ -744,7 +744,7 @@ | |||
| ignitionReliabilityEnd = 0.983077 | |||
| cycleReliabilityStart = 0.915385 | |||
| cycleReliabilityEnd = 0.983077 | |||
| techTransfer = RD-200:25 | |||
| techTransfer = RD-200:50 | |||
There was a problem hiding this comment.
Same question: Why give a full 50% transfer between the RD200 series and the RD107? They're not the same engine at all...
|
In the main this looks great, although I'm not sure about why you would remove the use of TF tech transfer branches and give a full 50% transfer even between separate engines. Can you go into the reasoning there? |
|
Do multiple tech transfers work properly now? I might have to fix it in that case. |
|
Finally loaded up the RO and RP-1 PRs ingame.
|
oh ugh thought I responded. Yes, they do. At first use of an engine, TF selects the branch with the highest transferred du (so they don't stack) but IMO that's correct. Format is (comma-separated list of configs):transferamount&next list:amount&.... |
|
I will fix this as soon as I get the time, and move the TF changes into a different PR when I redo reliability with a better grasp of statistics. |
This reverts commit cad0fa9.
|
Ok, changed tech transfer to use multiple tech transfer sources correctly. |
Based on new information, deprecate the XLR43. The XLR43-NA-1 will be moved into the NAA-75-110 config, and the XLR43-NA-3 will be moved to the LR89 config.
resolves #2507