-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #2394 - Expose terminal cursor #2397
Open
Garek33
wants to merge
16
commits into
KSP-KOS:develop
Choose a base branch
from
Garek33:dev-2394
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
f259489
New suffixes :cursorcol and :cursorrow for terminal - see #2394
Garek33 7133735
- new suffix terminal:put, see #2394
Garek33 0ce362d
Updated documentation for #2394
Garek33 0c48a6c
Added terminal:putln, aliasing global print
Garek33 bb539f7
Clarified docs for print at.
Garek33 091f0a2
Added terminal:putat, aliasing global print at
Garek33 1d3cb7f
Added convenience method terminal:movecursor
Garek33 2cb6c6b
Merge branch 'develop' into dev-2394
Garek33 2ecb3c1
Rework the SubBuffer/ScreenBuffer stack
Garek33 92b998b
fixes the cursor vanishing when scrolling after clearscreen
Garek33 1c78741
fixes artifacting on telnet clients
Garek33 1278c56
terminal:put suffixes now autocast to string
Garek33 9a61f2d
bumped .NET version to 4.5.1 because 4.5 is no longer supported
Garek33 2f36038
merged changes from develop since 2019
Garek33 b0d0764
Added additonal tests/examples for #2394 terminal cursor manipulation.
Garek33 acc98dc
moved CursorVisible to ScreenSnapshot
Garek33 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
@lazyglobal off. | ||
|
||
local teststring is "This is a teststring". | ||
local words is teststring:split(" "). | ||
|
||
print "The following lines should all look identical". | ||
print teststring. //comparison, do not go back to this line | ||
print words[0]. | ||
set terminal:cursorcol to words[0]:length + 1. | ||
set terminal:cursorrow to terminal:cursorrow - 1. | ||
print words[1]. | ||
set terminal:cursorrow to terminal:cursorrow - 1. | ||
set terminal:cursorcol to words[0]:length + words[1]:length + 2. | ||
print words[2] + " " + words[3]. | ||
print words[0] + " " + words[1]. | ||
set terminal:cursorrow to terminal:cursorrow - 2. | ||
set terminal:cursorcol to words[0]:length + words[1]:length +2. | ||
terminal:put(words[2]). | ||
set terminal:cursorrow to terminal:cursorrow + 1. | ||
set terminal:cursorcol to terminal:cursorcol - words[2]:length. | ||
terminal:put(words[2]). | ||
print " " + words[3]. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. This might explain a few other weird behaviours I've seen in the past.