#1665 clarify Orbit:MEANANOMALYATEPOCH docs #1696
Conversation
for the sake of other unaware rocket scientists
| traditionally done in radians, in keeping with the kOS standard | ||
| of making everything into degrees, they are given as degrees by | ||
| kOS. | ||
| kOS. Orbit epoch is a complex term, refer to `#1665<https://github.com/KSP-KOS/KOS/issues/1665>`_ for details. |
There was a problem hiding this comment.
I'm not sure I like the idea of pointing people at the github issue about the problem, since it will also contain confusing information about what the mod used to be like...
There was a problem hiding this comment.
I agree. It would be better if the documentation itself explained the concept of epoch. I'm not sure that we've actually fixed anything related to this though. @Dunbaratu were you going to add a suffix to handle the epoch issue in the review of #1660?
There was a problem hiding this comment.
I think it's just better than nothing. Might be reasonable to just notice that orbit epoch is not the same that the universe epoch. A link to KSP docs could be also helpful and better than to github issue.
I think something has to be done here. I'd lost a couple hours trying to catch a bug related to this.
|
@sshilovsky : The problem with the notion of putting in a temporary change to the docs until such a time as the #1665 is fixed.. is that the docs get published officially at the same time as the full releases do. So if we assume #1665 is in the next release, there won't be any window of time during which the edit you talked about would help. The edit we make should be the edit that makes the docs look like what we want them to look like after issue #1665 gets finished and closed. By the time the documentation change becomes public, that's what the situation will be. @hvacengi : I'm stalled on #1665 because @dewiniaid last said he was still going to mess with it a bit more, and I didn't want to go any further on it until I heard more about that. If he's not planning on doing it, then I may take over testing the problem and seeing what can be done about it. I do think we need something to make "find current position on orbit" more sane. At the moment the "mean anomaly at epoch" value is useless without knowing the epoch timestamp, which keeps on changing a LOT as the game progresses. I haven't figured out yet when and why it changes, bit it changes a lot. The game seems to very frequently recalc the Euclidian parameters for the orbit object, and each time it does so it seems to move the epoch again. |
|
Oh, I didn't see that #1665 was moved to v1.0.1 rather than v1.0.0. In that case there might be a need for a temp fix in the docs? |
|
@Dunbaratu err, I'm not an actual kOS developer and am not working on #1665, just a highly opinionated and technical user. Apologies if anything implied otherwise. |
|
I misspoke. I mean the person working on #1660 - @lamont-granquist |
|
Added to Milestone v1.1.0 because the issue this is connected to is in milestone V1.1.0 |
|
It looks like we added the |
for the sake of other unaware rocket scientists