Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Skip Splash Screen from SpaceDock #80

Merged
merged 4 commits into from
Oct 23, 2023
Merged

Conversation

netkan-bot
Copy link
Member

This pull request was automatically generated by SpaceDock on behalf of Falki, to add Skip Splash Screen to CKAN.

Please direct questions about this pull request to Falki.

Mod details

Key Value
Name Skip Splash Screen
Authors Falki
Abstract Skips the splash screen and health warning. To be used only for developing mods (faster iteration).
License MIT
Size 4.87 KiB
Homepage <>
Source code https://github.com/Falki-git/SkipSplashScreen

Description

Skips the splash screen and health warning. To be used only for developing mods (faster iteration).

Installation: Extract the contents of the .zip file into your KSP2 installation folder.

Requires: Space Warp + BepInEx. - v1.4.0 or later

This is an automated commit on behalf of Falki
@HebaruSan
Copy link
Member

Backslashes in ZIP again.

$ unzip -l Skip_Splash_Screen-1.1.0.zip
Archive:  Skip_Splash_Screen-1.1.0.zip
  Length      Date    Time    Name
---------  ---------- -----   ----
        0  2023-08-20 15:30   BepInEx\plugins\
     1066  2023-08-20 15:22   BepInEx\plugins\SkipSplashScreen\LICENSE
      158  2023-08-20 14:53   BepInEx\plugins\SkipSplashScreen\README.txt
     7168  2023-08-20 15:30   BepInEx\plugins\SkipSplashScreen\SkipSplashScreen.dll
      674  2023-08-20 15:30   BepInEx\plugins\SkipSplashScreen\swinfo.json
---------                     -------
     9066                     5 files

@Falki-git
Copy link
Contributor

Hey @HebaruSan, do you have an ETA for when the fix for backward slashes will be merged, as you mentioned in KSP-CKAN/CKAN#3893?
If it's gonna be a while still and since the fix from my side would be trivial, I'd rather just replace backward slashes with forward slashes and release the mod on CKAN.
Thanks!

@HebaruSan
Copy link
Member

HebaruSan commented Oct 23, 2023

Hi @Falki-git, sorry, it may be a little while. I have a fix in progress for KSP-CKAN/CKAN#3849 that I want to include, but it's complicated and I'm not sure it can be trusted, so I'm hoping to either find a critical bug that blocks it or convince myself that I've checked for every such bug and proven none exists.

If you do remove the backslashes on your end, then indeed we could move ahead with adding this mod, just let us know. As noted on the issue you linked, Powershell fixed this bug several years ago, see PowerShell/Microsoft.PowerShell.Archive#48. Running this in PowerShell installs the fix:

Install-Module Microsoft.PowerShell.Archive -MinimumVersion 1.2.3.0 -Repository PSGallery -Force
Import-Module Microsoft.PowerShell.Archive

This is an automated commit on behalf of Falki
@netkan-bot
Copy link
Member Author

This pull request was automatically generated by SpaceDock on behalf of Falki, to add Skip Splash Screen to CKAN.

Please direct questions about this pull request to Falki.

Mod details

Key Value
Name Skip Splash Screen
Authors Falki
Abstract Skips the splash screen and health warning. Gives the fastest possible load times. To be used only for developing mods (faster iteration).
License MIT
Size 5.39 KiB
Homepage <>
Source code https://github.com/Falki-git/SkipSplashScreen

Description

Skips the splash screen and health warning at game launch. It gives the fastest possible load times by eliminating everything except for loading of the game itself.
Intent for this mod is to be used only by modders as it provides fastest possible development iteration.

Installation: Extract the contents of the .zip file into your KSP2 installation folder.

Requires: Space Warp + BepInEx. - v1.4.0 or later

@Falki-git
Copy link
Contributor

Falki-git commented Oct 23, 2023

@HebaruSan, as suggested, I've updated the mod by only bumping the version and this time manually zipping it.
Thanks for your help!

Copy link
Member

@HebaruSan HebaruSan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, looks good! Thanks for the submission, as well as your patience and the update. 👍

@HebaruSan HebaruSan merged commit 7056721 into main Oct 23, 2023
1 check passed
@HebaruSan HebaruSan deleted the add/SkipSplashScreen branch October 23, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants