Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently the
download_hash
property of a module always containssha1
andsha256
, which is redundant. Thesha256
is better and can detect corrupt files well enough on its own. The client checks both hashes, which takes extra time after downloading a file.Changes
spec_version
is greater thanv1.34
(since the already-released clients in thev1.34
series require both). This will give us the option to save bot CPU the next time we increment the spec version.This will shave some time off the validation step after downloading a big mod.