Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
During KSP-CKAN/NetKAN#10108, we noticed that
replaced_by
is a bit janky.Causes
replaced_by
property in the installed module, not the available module, so if users install a module and then later we addreplaced_by
to migrate them to a new identifier, they won't see the replace checkbox unless they reinstall the mod to get the new metadata.replaced_by
isn't checked. So the user would have to reinstall manually, which mostly defeats the purpose.Changes
Now if you add
replaced_by
to a module, users who already have it installed will be prompted to reinstall it with the upgrade checkbox, after which they'll be prompted to replace it with the replace checkbox.replaced_by
could use more streamlining after this, but this will at least make it baseline usable.