Added Twig Filter to get the average color of an Image. Used in Email… #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ovascos
reviewed
Aug 22, 2024
| return sprintf("#%02x%02x%02x", $rgb["red"], $rgb["green"], $rgb["blue"]); | ||
| } | ||
|
|
||
| private function createImageFromFile(string $imagePath): \GdImage|false { |
There was a problem hiding this comment.
use statement for GdImage
maybe use null instead of false for "no image"
There was a problem hiding this comment.
false is returned from imagecreatefrom*** if an error happened. So false to be complient with that.
| @@ -1,7 +1,7 @@ | |||
| {# TODO embedd logo to make it independent of changes #} | |||
| <div class="head-wrap bg-primary" | |||
| {% if settings.get('style.bg_image') is not empty %} | |||
| style="background-image: url({{ absolute_url(settings.get('style.bg_image')) }})" | |||
| style="background-image: url({{ absolute_url(settings.get('style.bg_image')) }}); background-color: {{ absolute_url(settings.get('style.bg_image')) | average_color }}" | |||
There was a problem hiding this comment.
no absolute_url here, as this is the parameter for average_color. Use the file path instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Twig Filter to get the average color of an Image. Used in Email as bg-color