Klms wipe #119
Draft
Klms wipe #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
December 16, 2023 10:08
Ovascos
commented
Feb 21, 2024
| }); | ||
|
|
||
| $(document).ready(() => { | ||
| let wipeAdmin = new WipeAdmin(document.querySelector("form")); |
There was a problem hiding this comment.
I should change this to use an ID instead of form.
Ovascos
commented
Feb 21, 2024
| $result = $wipeService->wipe($wipe); | ||
| $this->assertFalse($result); | ||
| } | ||
| } |
There was a problem hiding this comment.
Add test that wipes every service (and its dependencies) individually to ensure that the dependencies are set correctly.
firegore
reviewed
Feb 23, 2024
| {% block siteheading %}<i class="far fa-solid fa-trash"></i> Wipe{% endblock %} | ||
| {% block main %} | ||
| <div class="clearfix mb-4"> | ||
| <p>Welche Bereiche sollen zurückgesetzt werden?<br><small class="text-muted">(Abhänigkeiten werden ebenfalls zurückgesetzt.)</small> |
There was a problem hiding this comment.
Suggested change
| <p>Welche Bereiche sollen zurückgesetzt werden?<br><small class="text-muted">(Abhänigkeiten werden ebenfalls zurückgesetzt.)</small> | |
| <p>Welche Bereiche sollen zurückgesetzt werden?<br><small class="text-muted">(Abhängigkeiten werden ebenfalls zurückgesetzt.)</small> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.