Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: figma emoji svg 추출 #83

Closed
wants to merge 3 commits into from
Closed

Chore: figma emoji svg 추출 #83

wants to merge 3 commits into from

Conversation

daun-up
Copy link
Collaborator

@daun-up daun-up commented Aug 26, 2024

#️⃣연관된 이슈

#13

📝작업 내용

온보딩에 필요한 이모지 svg 추출 작업을 진행하였습니다.

스크린샷 2024-08-26 오전 11 35 53

스크린샷 (선택)

스크린샷 2024-08-26 오전 11 36 23

@daun-up daun-up self-assigned this Aug 26, 2024
@daun-up daun-up changed the title chore: figma emoji svg 추출 Chore: figma emoji svg 추출 Aug 26, 2024
Choi-Jiwon-38
Choi-Jiwon-38 reviewed Aug 26, 2024
View reviewed changes
Copy link
Member

@Choi-Jiwon-38 Choi-Jiwon-38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

혹시 아래 커밋들이 이번 PR에 포함된 이유가 있을까용?

온보딩 쪽 작업 사항이 chore/#13-svg로 잘못 커밋된 것이라면 온보딩 쪽 브랜치에서 관련 커밋들을 cherry pick해서 옮겨두고 여기서는 svg 추출 건만 남기는 것도 좋아보여요.

@daun-up daun-up closed this Aug 26, 2024
@daun-up daun-up deleted the chore/#13-svg branch August 26, 2024 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Choi-Jiwon-38 Choi-Jiwon-38 Choi-Jiwon-38 left review comments

@j-myeong j-myeong Awaiting requested review from j-myeong

@hyeonseung-lee hyeonseung-lee Awaiting requested review from hyeonseung-lee

Assignees

@daun-up daun-up

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daun-up @Choi-Jiwon-38