Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified: Change tab from hard to soft (4 spaces) #30

Closed
wants to merge 1 commit into from

Conversation

futoase
Copy link
Contributor

@futoase futoase commented Sep 30, 2013

improve indent of include files.

change tab from hard to soft (4 spaces).

@muojp
Copy link
Contributor

muojp commented Sep 30, 2013

Thanks for your contribution. We're sorry but we could not merge this pull-request this time.

Reasons:

  • We recognize it's important and it is not unified in current tree.
  • Hard-tabs vs soft-tabs is not a tiny change. it could effect every code written on this project.
  • So we need to discuss and determine code styling prior to start making actual changes.

Instead of merging, we'll welcome you to join us discussing code styling. We're planning to apply automatic code formatter once prepared (because we need to sync our in-company tree and OSS version smoothly). #32 would be the nice place to have further discussion.

@futoase
Copy link
Contributor Author

futoase commented Oct 1, 2013

We're planning to apply automatic code formatter once prepared
#32 would be the nice place to have further discussion.

I understand.

@muojp muojp closed this Oct 1, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants